Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 583233004: Bump BlinkGCPlugin version to 11 to force redownload of Clang 216630 (Closed)

Created:
6 years, 3 months ago by hans
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bump BlinkGCPlugin version to 11 to force redownload of Clang 216630 When 216630 was rolled in, there was one roll that got reverted, and then we re-built packages for the next one. However, some devs and maybe bots who didn't sync to the revert got stuck with the old binaries which would now mismatch against goma's checksum. No behavior change. BUG=415883 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/69f702ce8beb294a2e9af71865a427994cdd24a3

Patch Set 1 #

Patch Set 2 : Magic whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
A + tools/whitespace.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hans
Please take a look.
6 years, 3 months ago (2014-09-19 19:45:25 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-09-19 19:46:46 UTC) #4
hans
Mac and Linux both re-downloaded and successfully compile stuff: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clang_dbg/builds/8459 http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/4496 I'll commit this now.
6 years, 3 months ago (2014-09-19 20:00:21 UTC) #5
Nico
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_rel_precise32/builds/117 on the first patch set happened to Do Stuff too)
6 years, 3 months ago (2014-09-19 20:01:19 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/69f702ce8beb294a2e9af71865a427994cdd24a3 Cr-Commit-Position: refs/heads/master@{#295768}
6 years, 3 months ago (2014-09-19 20:07:21 UTC) #7
hans
6 years, 3 months ago (2014-09-19 20:07:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 69f702c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698