Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 583233003: Remove WebRequestAPI's dependency on rule_registry_service. (Closed)

Created:
6 years, 3 months ago by Xi Han
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use RulesRegistry::WebViewKey to replace RulesRegistryService::WebViewKey in web_request_api. BUG=352293 Committed: https://crrev.com/dff8fb5643fdf695854c863971b6b42f9c3e2bf7 Cr-Commit-Position: refs/heads/master@{#295829}

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Xi Han
6 years, 3 months ago (2014-09-19 15:15:49 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-19 20:53:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583233003/20001
6 years, 3 months ago (2014-09-19 21:09:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583233003/20001
6 years, 3 months ago (2014-09-19 21:09:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11494)
6 years, 3 months ago (2014-09-19 21:39:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583233003/20001
6 years, 3 months ago (2014-09-19 23:31:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4f40408389b050e03e66ca0a295076ac96168a5e
6 years, 3 months ago (2014-09-20 00:24:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 00:25:19 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dff8fb5643fdf695854c863971b6b42f9c3e2bf7
Cr-Commit-Position: refs/heads/master@{#295829}

Powered by Google App Engine
This is Rietveld 408576698