mac: Disable parts of ProcessInfoSnapshotMacTest on OSX 10.9+.

mac: Disable parts of ProcessInfoSnapshotMacTest on OSX 10.9+.

Collection of memory statistics is broken in OSX 10.9+. I've disabled the
checks in ProcessInfoSnapshotMacTest that expect collection of memory
statistics to work.

BUG=383553, 390276
Committed: https://crrev.com/60bc59460320221de4bb233d28efed99dd827b51
Cr-Commit-Position: refs/heads/master@{#296453}

[erikchen, 2014-09-19 18:20:48]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2014-09-19 18:20:48]

mark: Please review.

[Mark Mentovai, 2014-09-19 18:26:23]

Can you also disable or do something else about the code that tries to collect
the snapshots? Notably, the

[pid:tid:mmdd/hhmmss:ERROR:process_info_snapshot_mac.cc(211)] Failure running
/usr/bin/top to acquire data.

that shows up on 10.9. We should do something about that.

(from crbug 383553)

[erikchen, 2014-09-19 21:18:37]

Patchset #2 (id:20001) has been deleted

[erikchen, 2014-09-19 21:18:42]

Patchset #2 (id:40001) has been deleted

[erikchen, 2014-09-19 21:19:52]

I updated the code to just call ps, since top returns no additional useful
information on 10.9+. I also updated the logic in ps, which was incorrect.

On 2014/09/19 18:26:23, Mark Mentovai wrote:
> Can you also disable or do something else about the code that tries to collect
> the snapshots? Notably, the
> 
> [pid:tid:mmdd/hhmmss:ERROR:process_info_snapshot_mac.cc(211)] Failure running
> /usr/bin/top to acquire data.
> 
> that shows up on 10.9. We should do something about that.
> 
> (from crbug 383553)

[erikchen, 2014-09-19 21:23:05]

Err, not ready for review. Have to update the unit tests again.

On Fri, Sep 19, 2014 at 2:19 PM, <erikchen@chromium.org> wrote:

> I updated the code to just call ps, since top returns no additional useful
> information on 10.9+. I also updated the logic in ps, which was incorrect.
>
>
> On 2014/09/19 18:26:23, Mark Mentovai wrote:
>
>> Can you also disable or do something else about the code that tries to
>> collect
>> the snapshots? Notably, the
>>
>
>  [pid:tid:mmdd/hhmmss:ERROR:process_info_snapshot_mac.cc(211)] Failure
>> running
>> /usr/bin/top to acquire data.
>>
>
>  that shows up on 10.9. We should do something about that.
>>
>
>  (from crbug 383553)
>>
>
>
>
> https://codereview.chromium.org/583193006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[erikchen, 2014-09-19 21:35:21]

mark: PTAL

[Mark Mentovai, 2014-09-19 22:21:07]

LGTM

[erikchen, 2014-09-19 22:22:37]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583193006/80001

[commit-bot: I haz the power, 2014-09-19 22:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:49:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-19 22:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:49:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2014-09-20 00:00:20]

erikchen@chromium.org changed reviewers:
+ thakis@chomium.org

[erikchen, 2014-09-20 00:00:20]

thakis: Looking for an OWNER review.

[erikchen, 2014-09-24 17:28:37]

erikchen@chromium.org changed reviewers:
+ thestig@chromium.org
- thakis@chomium.org

[erikchen, 2014-09-24 17:28:38]

thestig: Looking for an OWNER review.

[Lei Zhang, 2014-09-24 17:39:34]

lgtm

[erikchen, 2014-09-24 17:40:16]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-09-24 17:41:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/583193006/80001

[commit-bot: I haz the power, 2014-09-24 17:47:13]

Committed patchset #3 (id:80001) as b8cc74d7d5737bd726dbdeb5ff685bbd307c2883

[commit-bot: I haz the power, 2014-09-24 17:47:46]

Patchset 3 (id:??) landed as
https://crrev.com/60bc59460320221de4bb233d28efed99dd827b51
Cr-Commit-Position: refs/heads/master@{#296453}