cc: Cleanup Layer::SetNeedsDisplayInRect

cc/layers/image_layer.cc

Index: cc/layers/image_layer.cc
diff --git a/cc/layers/image_layer.cc b/cc/layers/image_layer.cc
index e02fc62dfe50082d0ca3fd08c206b7683561e66a..8ba1908131d2c2145da17d00b2346c912112ec2f 100644
--- a/cc/layers/image_layer.cc
+++ b/cc/layers/image_layer.cc
@@ -43,11 +43,10 @@ void ImageLayer::SetTexturePriorities(const PriorityCalculator& priority_calc) {
 bool ImageLayer::Update(ResourceUpdateQueue* queue,
                         const OcclusionTracker* occlusion) {
   CreateUpdaterIfNeeded();
-  if (needs_display_) {
-    updater_->set_bitmap(bitmap_);
+  if (!updater_->UsingBitmap(bitmap_)) {

[enne (OOO), 2013/07/30 20:01:27]

The reason this code was broken before was that ImageLayer::SetBitmap above was
calling SetNeedsDisplay() when the bounds of the layer was empty.  This
prevented needs_display_ from getting set to true, causing the tile size to not
be updated in this conditional.  The tile size being zero means that we were
requesting shared memory of size zero which blew up.

This code is really trying to check that the bitmap has changed, and so check
this explicitly.  It's also a little sketchy that it was unsetting
needs_display_ here.

+    updater_->SetBitmap(bitmap_);
     UpdateTileSizeAndTilingOption();
     InvalidateContentRect(gfx::Rect(content_bounds()));
-    needs_display_ = false;
   }
   return TiledLayer::Update(queue, occlusion);
 }