Build clang tools using CMake

Build clang tools using CMake

This patch adds the CMakeLists.txt necessary to build clang tools using
CMake. The build files have also been refactored by creating a
top-level CMakeLists.txt. The list of tools to be built can be
controlled by setting ${CHROMIUM_TOOLS}. Tools are now installed with
a CMake rule rather than a manual cp, which should make this logic a
little more platform independent.

R=hans@chromium.org

Committed: https://crrev.com/efc44699afca7b3935896754dc7da39e19edb36c
Cr-Commit-Position: refs/heads/master@{#296081}

[dcheng, 2014-09-19 07:20:29]

dcheng@chromium.org changed reviewers:
+ hans@chromium.org, thakis@chromium.org

[dcheng, 2014-09-19 15:03:46]

Whee. CMake is fun.

[hans, 2014-09-19 23:49:33]

This lgtm. Thanks!

[hans, 2014-09-20 00:20:04]

Trying this out locally (with package.sh), it seems like stuff gets built
correctly, but then it fails to run the tests.

I think you can try this by passing --run-tests to update.sh. This is the error
I get:

-- Install configuration: ""
-- Installing:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-- Up-to-date:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-- Installing:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.so
-- Up-to-date:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.so
+ popd
/work/chromium/src
+ [[ -n yes ]]
+ for CHROME_TOOL_DIR in '${chrome_tools//;/ }'
+ TOOL_SRC_DIR=tools/clang/scripts/../plugins
+
TOOL_BUILD_DIR=/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins
+++ ls
/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins/lib/
ls: cannot access
/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins/lib/:
No s
uch file or directory
++ basename
basename: missing operand
Try `basename --help' for more information.
+ LIBNAME=


Check out the code in the if [[ -n "$run_tests" ]]; clause:
I think it sets TOOL_SRC_DIR wrong.

[dcheng, 2014-09-20 00:58:31]

On 2014/09/20 at 00:20:04, hans wrote:
> Trying this out locally (with package.sh), it seems like stuff gets built
correctly, but then it fails to run the tests.
> 
> I think you can try this by passing --run-tests to update.sh. This is the
error I get:
> 
> -- Install configuration: ""
> -- Installing:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -- Up-to-date:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
> -- Installing:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.so
> -- Up-to-date:
/work/chromium/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.so
> + popd
> /work/chromium/src
> + [[ -n yes ]]
> + for CHROME_TOOL_DIR in '${chrome_tools//;/ }'
> + TOOL_SRC_DIR=tools/clang/scripts/../plugins
> +
TOOL_BUILD_DIR=/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins
> +++ ls
/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins/lib/
> ls: cannot access
/work/chromium/src/tools/clang/scripts/../../../third_party/llvm/../llvm-build/Release+Asserts/tools/clang/tools/chrome-plugins/lib/:
No s
> uch file or directory
> ++ basename
> basename: missing operand
> Try `basename --help' for more information.
> + LIBNAME=
> 
> 
> Check out the code in the if [[ -n "$run_tests" ]]; clause:
> I think it sets TOOL_SRC_DIR wrong.

Yeah, I need to rethink my approach. I fixed it to populate the environment
correctly, but now that all the plugins are built into the same directory, the
shell script falls on its face since it just grabs the first one.

[hans, 2014-09-20 15:57:00]

On 2014/09/20 00:58:31, dcheng (OOO) wrote:
> Yeah, I need to rethink my approach. I fixed it to populate the environment
> correctly, but now that all the plugins are built into the same directory, the
> shell script falls on its face since it just grabs the first one.

Would it be possible to make the cmake build generate a "check" target that
would run the tests for all plugins?

[dcheng, 2014-09-20 18:32:45]

Yep! I drank some more cmake koolaid last night and uploaded a patch to do just
that.

[hans, 2014-09-22 20:16:17]

lgtm

I tried this locally (built a new Clang package on Linux) and it worked.

[dcheng, 2014-09-22 21:38:54]

OK, so I did some testing on my Linux machine... and the clang refactoring tools
don't like there. Sigh. The plugins build fine--it's just the clang tools for
refactoring that are broken.

Given that the build for the tools was broken anyway before this change, and now
it's less broken since it builds on Mac, would you be OK with landing this as is
and fixing Linux in a followup?

[dcheng, 2014-09-22 21:39:09]

On 2014/09/22 at 21:38:54, dcheng wrote:
> OK, so I did some testing on my Linux machine... and the clang refactoring
tools don't like there. Sigh. The plugins build fine--it's just the clang tools
for refactoring that are broken.
> 
> Given that the build for the tools was broken anyway before this change, and
now it's less broken since it builds on Mac, would you be OK with landing this
as is and fixing Linux in a followup?

Err, s/like/link/

[hans, 2014-09-22 23:00:09]

On 2014/09/22 21:39:09, dcheng wrote:
> > Given that the build for the tools was broken anyway before this change, and
> now it's less broken since it builds on Mac, would you be OK with landing this
> as is and fixing Linux in a followup?
> 
> Err, s/like/link/

Yup, I'm OK with this.

[dcheng, 2014-09-22 23:03:33]

Committed patchset #10 (id:180001) manually as efc4469 (presubmit successful).

[commit-bot: I haz the power, 2014-09-22 23:03:36]

Patchset 10 (id:??) landed as
https://crrev.com/efc44699afca7b3935896754dc7da39e19edb36c
Cr-Commit-Position: refs/heads/master@{#296081}