chrome/browser/chromeos/policy/device_local_account_external_data_manager.h - Issue 58313002: Removed the PolicyDefinitionList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_external_data_manager.h

Issue 58313002: Removed the PolicyDefinitionList. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome-policy-schema-10-use-registry

Patch Set: rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc ('k') | chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_external_data_manager.h

diff --git a/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h b/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h

index 68edd01cd30a14432dbc8fdbf5b25d10ce38547a..473b93730f8299e7303d3a8f085fe00fd5b9a1c8 100644

--- a/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h

+++ b/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h

@@ -11,6 +11,7 @@

#include "base/compiler_specific.h"

#include "base/memory/ref_counted.h"

#include "chrome/browser/chromeos/policy/cloud_external_data_manager_base.h"

+#include "components/policy/core/common/policy_details.h"

namespace base {

class SequencedTaskRunner;

@@ -18,7 +19,6 @@ class SequencedTaskRunner;

namespace policy {

-struct PolicyDefinitionList;

class ResourceCache;

// Downloads, verifies, caches and retrieves external data referenced by

@@ -39,7 +39,7 @@ class DeviceLocalAccountExternalDataManager

friend class DeviceLocalAccountExternalDataService;

friend class base::RefCounted<DeviceLocalAccountExternalDataManager>;

- // The |policy_definitions| are used to determine the maximum size that the

+ // |get_policy_details| is used to determine the maximum size that the

// data referenced by each policy can have. Download scheduling, verification,

// caching and retrieval tasks are done via the |backend_task_runner|, which

// must support file I/O. Network I/O is done via the |io_task_runner|. The

@@ -50,7 +50,7 @@ class DeviceLocalAccountExternalDataManager

// cache, all its users must access the cache via |backend_task_runner| only.

DeviceLocalAccountExternalDataManager(

const std::string& account_id,

- const PolicyDefinitionList* policy_definitions,

+ const GetChromePolicyDetailsCallback& get_policy_details,

scoped_refptr<base::SequencedTaskRunner> backend_task_runner,

scoped_refptr<base::SequencedTaskRunner> io_task_runner,

ResourceCache* resource_cache);