Chromium Code Reviews| Index: components/policy/core/common/policy_details.h |
| diff --git a/components/policy/core/common/policy_details.h b/components/policy/core/common/policy_details.h |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..25258d3726a093e884949e81fd5f9272ce198313 |
| --- /dev/null |
| +++ b/components/policy/core/common/policy_details.h |
| @@ -0,0 +1,42 @@ |
| +// Copyright 2013 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#ifndef COMPONENTS_POLICY_CORE_COMMON_POLICY_DETAILS_H_ |
| +#define COMPONENTS_POLICY_CORE_COMMON_POLICY_DETAILS_H_ |
| + |
| +#include <string> |
| + |
| +#include "base/callback_forward.h" |
| +#include "components/policy/policy_export.h" |
| + |
| +namespace policy { |
| + |
| +// Contains read-only metadata about a Chrome policy. |
| +struct POLICY_EXPORT PolicyDetails { |
| + // True if this policy has been deprecated. |
| + bool is_deprecated; |
| + |
| + // True if this policy is a ChromeOS device policy. |
|
bartfab (slow)
2013/11/05 18:18:33
Nit: s/ChromeOS/Chrome OS/
Joao da Silva
2013/11/07 20:27:27
Done.
|
| + bool is_device_policy; |
| + |
| + // The id of the protobuf field that contains this policy, |
| + // in the cloud policy protobuf. |
| + int id; |
|
bartfab (slow)
2013/11/05 18:18:33
Do we ever use this for anything?
Joao da Silva
2013/11/07 20:27:27
It's what the PolicyStatisticsCollector samples fo
|
| + |
| + // If this policy references external data to be downloaded then |
|
bartfab (slow)
2013/11/05 18:18:33
Could you drop the part "to be downloaded"? As Mat
Joao da Silva
2013/11/07 20:27:27
Done.
|
| + // this is the maximum size allowed for that external data. |
| + // Otherwise this field is 0 and doesn't have any meaning. |
| + size_t max_external_data_size; |
|
bartfab (slow)
2013/11/05 18:18:33
Nit: #include "base/basictypes.h"
Joao da Silva
2013/11/07 20:27:27
Done.
|
| +}; |
| + |
| +// A typedef for functions that match the signature of |
| +// GetChromePolicyDetails(). This can be used to inject that |
| +// function into objects, so that it can be easily mocked for |
|
bartfab (slow)
2013/11/05 18:18:33
Nice mocking mechanism.
Joao da Silva
2013/11/07 20:27:27
Daniel and I have remarked how the component refac
|
| +// tests. |
| +typedef base::Callback<const PolicyDetails*(const std::string&)> |
| + GetChromePolicyDetailsCallback; |
| + |
| +} // namespace policy |
| + |
| +#endif // COMPONENTS_POLICY_CORE_COMMON_POLICY_DETAILS_H_ |