content/shell/renderer/test_runner/web_permissions.cc - Issue 583113002: Abstract class WebTestDelegate to chromium c++ style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_permissions.cc

Issue 583113002: Abstract class WebTestDelegate to chromium c++ style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test_runner Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/web_frame_test_proxy.h ('k') | content/shell/renderer/test_runner/web_test_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_permissions.cc

diff --git a/content/shell/renderer/test_runner/web_permissions.cc b/content/shell/renderer/test_runner/web_permissions.cc

index c861e0909fd12febbe998ce8eda9ae90280f67dc..323224480ef8ed3db3ba1a1f235aa997b1439859 100644

--- a/content/shell/renderer/test_runner/web_permissions.cc

+++ b/content/shell/renderer/test_runner/web_permissions.cc

@@ -4,8 +4,8 @@

#include "content/shell/renderer/test_runner/web_permissions.h"

-#include "content/shell/renderer/test_runner/WebTestDelegate.h"

#include "content/shell/renderer/test_runner/test_common.h"

+#include "content/shell/renderer/test_runner/web_test_delegate.h"

#include "third_party/WebKit/public/platform/WebCString.h"

#include "third_party/WebKit/public/platform/WebURL.h"

@@ -21,7 +21,7 @@ bool WebPermissions::allowImage(bool enabled_per_settings,

const blink::WebURL& image_url) {

bool allowed = enabled_per_settings && images_allowed_;

if (dump_callbacks_ && delegate_) {

- delegate_->printMessage(std::string("PERMISSION CLIENT: allowImage(") +

+ delegate_->PrintMessage(std::string("PERMISSION CLIENT: allowImage(") +

NormalizeLayoutTestURL(image_url.spec()) + "): " +

(allowed ? "true" : "false") + "\n");

}

@@ -31,7 +31,7 @@ bool WebPermissions::allowImage(bool enabled_per_settings,

bool WebPermissions::allowMedia(const blink::WebURL& image_url) {

bool allowed = media_allowed_;

if (dump_callbacks_ && delegate_)

- delegate_->printMessage(std::string("PERMISSION CLIENT: allowMedia(") +

+ delegate_->PrintMessage(std::string("PERMISSION CLIENT: allowMedia(") +

NormalizeLayoutTestURL(image_url.spec()) + "): " +

(allowed ? "true" : "false") + "\n");

return allowed;

@@ -41,7 +41,7 @@ bool WebPermissions::allowScriptFromSource(bool enabled_per_settings,

const blink::WebURL& scriptURL) {

bool allowed = enabled_per_settings && scripts_allowed_;

if (dump_callbacks_ && delegate_) {

- delegate_->printMessage(

+ delegate_->PrintMessage(

std::string("PERMISSION CLIENT: allowScriptFromSource(") +

NormalizeLayoutTestURL(scriptURL.spec()) + "): " +

(allowed ? "true" : "false") + "\n");