Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 583093002: Fix more references to webkit's run_webkit_tests.py. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix more references to webkit's run_webkit_tests.py. Change the PRESUBMIT to call the script from Blink (run-webkit-tests) directly. BUG=338338 TEST=None R=dpranke@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/76ef458065798bc70114854cf4b51827005448a1 Cr-Commit-Position: refs/heads/master@{#295883}

Patch Set 1 #

Total comments: 1

Patch Set 2 : dpranke review #

Total comments: 1

Patch Set 3 : rm TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M WATCHLISTS View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/PRESUBMIT.py View 1 2 1 chunk +3 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
tfarina
Fixes the entries I found with: $ g grep \'layout_tests\' I will fix the ones ...
6 years, 3 months ago (2014-09-19 03:08:25 UTC) #1
Dirk Pranke
https://codereview.chromium.org/583093002/diff/1/content/test/PRESUBMIT.py File content/test/PRESUBMIT.py (right): https://codereview.chromium.org/583093002/diff/1/content/test/PRESUBMIT.py#newcode42 content/test/PRESUBMIT.py:42: stdout_data = subproc.communicate()[0] If we're changing this at all, ...
6 years, 3 months ago (2014-09-19 18:27:34 UTC) #2
tfarina
Done. PTAL.
6 years, 3 months ago (2014-09-20 00:48:13 UTC) #3
Dirk Pranke
lgtm with comment fixed. https://codereview.chromium.org/583093002/diff/20001/content/test/PRESUBMIT.py File content/test/PRESUBMIT.py (right): https://codereview.chromium.org/583093002/diff/20001/content/test/PRESUBMIT.py#newcode29 content/test/PRESUBMIT.py:29: # TODO(ukai): consolidate run-webkit-tests --lint-test-files ...
6 years, 3 months ago (2014-09-20 00:58:00 UTC) #4
tfarina
TODO removed.
6 years, 3 months ago (2014-09-20 02:50:39 UTC) #5
tfarina
TBR sky for this (python only reviewed by Dirk).
6 years, 3 months ago (2014-09-20 17:42:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/583093002/40001
6 years, 3 months ago (2014-09-20 17:44:06 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 848e215a33928e215f37376654ab863b18817ff6
6 years, 3 months ago (2014-09-20 18:21:43 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 18:22:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76ef458065798bc70114854cf4b51827005448a1
Cr-Commit-Position: refs/heads/master@{#295883}

Powered by Google App Engine
This is Rietveld 408576698