Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 583063002: QUIC - Don't close the QUIC connection if server config update message (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: track successful handling of server config update message Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_crypto_client_stream.cc
diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc
index 4d9d032a9041b0c9827818d6d4f6564fe45448cc..efc81aa39ac6b30c2ebd8c58c62f514672ed1be5 100644
--- a/net/quic/quic_crypto_client_stream.cc
+++ b/net/quic/quic_crypto_client_stream.cc
@@ -448,17 +448,21 @@ void QuicCryptoClientStream::DoHandshakeLoop(
void QuicCryptoClientStream::DoInitializeServerConfigUpdate(
QuicCryptoClientConfig::CachedState* cached) {
+ bool update_ignored = false;
if (!server_id_.is_https()) {
// We don't check the certificates for insecure QUIC connections.
SetCachedProofValid(cached);
next_state_ = STATE_VERIFY_PROOF_DONE;
- return;
- }
- if (!cached->IsEmpty() && !cached->signature().empty()) {
+ } else if (!cached->IsEmpty() && !cached->signature().empty()) {
// Note that we verify the proof even if the cached proof is valid.
DCHECK(crypto_config_->proof_verifier());
next_state_ = STATE_VERIFY_PROOF;
+ } else {
+ update_ignored = true;
+ next_state_ = STATE_VERIFY_PROOF_DONE;
}
+ UMA_HISTOGRAM_BOOLEAN("Net.QuicNumServerConfigUpdateMessagesIgnored",
Alexei Svitkine (slow) 2014/09/19 17:08:04 Nit: How about naming this Net.QuicNumServerConfig
ramant (doing other things) 2014/09/19 17:17:07 Done.
+ update_ignored);
}
QuicAsyncStatus QuicCryptoClientStream::DoVerifyProof(
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698