 Chromium Code Reviews
 Chromium Code Reviews Issue 583043005:
  Pending tasks in a message loop should be deleted before shutting down Blink  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 583043005:
  Pending tasks in a message loop should be deleted before shutting down Blink  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: base/message_loop/message_loop.h | 
| diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h | 
| index 8db1e77daf38b21e191df7c0108b6abe0d6571fe..ca184e80e91d47be0b090c96df715bba1c27d7d7 100644 | 
| --- a/base/message_loop/message_loop.h | 
| +++ b/base/message_loop/message_loop.h | 
| @@ -371,6 +371,11 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate { | 
| void AddTaskObserver(TaskObserver* task_observer); | 
| void RemoveTaskObserver(TaskObserver* task_observer); | 
| + // Delete tasks that haven't run yet without running them. Used in the | 
| + // destructor to make sure all the task's destructors get called. Returns | 
| + // true if some work was done. | 
| + bool DeletePendingTasks(); | 
| 
jamesr
2014/09/22 14:38:03
this doesn't make sense.  ~MessageLoop() does the
 | 
| + | 
| #if defined(OS_WIN) | 
| void set_os_modal_loop(bool os_modal_loop) { | 
| os_modal_loop_ = os_modal_loop; | 
| @@ -418,11 +423,6 @@ class BASE_EXPORT MessageLoop : public MessagePump::Delegate { | 
| // Adds the pending task to delayed_work_queue_. | 
| void AddToDelayedWorkQueue(const PendingTask& pending_task); | 
| - // Delete tasks that haven't run yet without running them. Used in the | 
| - // destructor to make sure all the task's destructors get called. Returns | 
| - // true if some work was done. | 
| - bool DeletePendingTasks(); | 
| - | 
| // Returns the TaskAnnotator which is used to add debug information to posted | 
| // tasks. | 
| debug::TaskAnnotator* task_annotator() { return &task_annotator_; } |