Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 58303002: Docserver: Clean up APIListDataSourceTest a bit by constructing a full (Closed)

Created:
7 years, 1 month ago by not at google - send to devlin
Modified:
7 years, 1 month ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Docserver: Clean up APIListDataSourceTest a bit by constructing a full ServerInstance rather than a mash of ad-hoc fake classes. When APIListDataSource is a DataSource then that's what it will take, and an upcoming change either needs to add more fake classes or convert to this. R=jyasskin@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232860

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -46 lines) Patch
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source_test.py View 1 2 chunks +43 lines, -36 lines 0 comments Download
M chrome/common/extensions/docs/server2/server_instance.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
If you're curious, this is prompted by https://codereview.chromium.org/48263002/diff/290001/chrome/common/extensions/docs/server2/api_list_data_source_test.py https://codereview.chromium.org/58303002/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (left): https://codereview.chromium.org/58303002/diff/30001/chrome/common/extensions/docs/server2/api_list_data_source.py#oldcode41 chrome/common/extensions/docs/server2/api_list_data_source.py:41: public_template_path, ...
7 years, 1 month ago (2013-11-04 19:30:45 UTC) #1
Jeffrey Yasskin
lgtm
7 years, 1 month ago (2013-11-04 23:10:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/58303002/30001
7 years, 1 month ago (2013-11-05 00:29:02 UTC) #3
not at google - send to devlin
7 years, 1 month ago (2013-11-05 00:56:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r232860.

Powered by Google App Engine
This is Rietveld 408576698