Solo gp

include/gpu/GrProgramElement.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrProgramElement_DEFINED
 #define GrProgramElement_DEFINED
 
 #include "SkRefCnt.h"
 #include "SkTArray.h"
 
 class GrGpuResourceRef;
 
 /**
- * Base class for GrEffect (and future GrGeometryProcessor). GrDrawState uses this to manage
- * transitioning a GrEffect from being owned by a client to being scheduled for execution. It
+ * Base class for GrProcessor (and future GrGeometryProcessor). GrDrawState uses this to manage

[bsalomon, 2014/09/22 14:56:38]

delete the (and future ...) ?

Do you think it makes sense to keep this separate from GrProcessor? (I still do
think so).

[joshua.litt, 2014/09/22 18:14:44]

Yes definitely, at the very least lets see how the XferProcessor affects things.

[bsalomon, 2014/09/22 19:15:37]

Shouldn't it just read "Base class for GrProcessor."?

I thought it went:

                              GrFragmentProcessor
GrProgramElement->GrProcessor<
                              GrGeometryProcessor

+ * transitioning a GrProcessor from being owned by a client to being scheduled for execution. It
  * converts resources owned by the effect from being ref'ed to having pending reads/writes.
  *
  * All GrGpuResource objects owned by a GrProgramElement or derived classes (either directly or
  * indirectly) must be wrapped in a GrGpuResourceRef and registered with the GrProgramElement using
  * addGpuResource(). This allows the regular refs to be converted to pending IO events
  * when the program element is scheduled for deferred execution.
  */
 class GrProgramElement : public SkNoncopyable {
 public:
     SK_DECLARE_INST_COUNT_ROOT(GrProgramElement)
@@ skipping 58 matching lines @@
 
     SkSTArray<4, const GrGpuResourceRef*, true> fGpuResources;
 
     // Only this class can access convertRefToPendingExecution() and completedExecution().
     template <typename T> friend class GrProgramElementRef;
 
     typedef SkNoncopyable INHERITED;
 };
 
 #endif