Issue 582933003: Revert of Cleanup: Remove remaining generated extensions APIs on Android.

Issue 582933003: Revert of Cleanup: Remove remaining generated extensions APIs on Android. (Closed)

Created:
6 years, 3 months ago by Lei Zhang

Modified:
6 years, 3 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@extclean4

Project:
chromium

Visibility:
Public.

Revert of Cleanup: Remove remaining generated extensions APIs on Android. (patchset #4 id:60001 of https://codereview.chromium.org/573933002/) Reason for revert: Android bot fails with error: gen/extensions/common/api/generated_schemas.cc: No such file or directory Original issue's description: > Cleanup: Remove remaining generated extensions APIs on Android. > > BUG=305852 > > Committed: https://crrev.com/379f0be47f454cce5c912f25d1b3302ba679b472 > Cr-Commit-Position: refs/heads/master@{#295669} TBR=yoz@chromium.org NOTREECHECKS=true NOTRY=true BUG=305852 Committed: https://crrev.com/b2454bd7f7abf05795473f41d2b06a773ae59d76 Cr-Commit-Position: refs/heads/master@{#295670}

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -90 lines)			Patch
M	chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc	View	6 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	5 chunks	+40 lines, -40 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	6 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/schemas.gypi	View	3 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/chrome_extensions_client.cc	View	5 chunks	+2 lines, -14 lines	0 comments	Download
M	extensions/common/api/schemas.gypi	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Created Revert of Cleanup: Remove remaining generated extensions APIs on Android.

6 years, 3 months ago (2014-09-19 06:19:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582933003/1

6 years, 3 months ago (2014-09-19 06:20:17 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as e6b80a0a70ee00bd10faadac02fb4ab2b0853586

6 years, 3 months ago (2014-09-19 06:20:44 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 06:23:11 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b2454bd7f7abf05795473f41d2b06a773ae59d76
Cr-Commit-Position: refs/heads/master@{#295670}