subprocess2.py - Issue 582933002: Make check_output of subprocess2 compatible with Python's subprocess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: subprocess2.py

Issue 582933002: Make check_output of subprocess2 compatible with Python's subprocess. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Simplified per iannucci suggestion. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: subprocess2.py

diff --git a/subprocess2.py b/subprocess2.py

index 9f547a63bbb84939d9ff29010abee0a99e23cb7d..ec190ec727c10a6d209240cabe3bcd3d1e5fbbef 100644

--- a/subprocess2.py

+++ b/subprocess2.py

@@ -34,8 +34,8 @@ SUBPROCESS_CLEANUP_HACKED = False

class CalledProcessError(subprocess.CalledProcessError):

"""Augment the standard exception with more data."""

def __init__(self, returncode, cmd, cwd, stdout, stderr):

- super(CalledProcessError, self).__init__(returncode, cmd)

- self.stdout = stdout

+ super(CalledProcessError, self).__init__(returncode, cmd, output=stdout)

+ self.stdout = self.output # for backward compatability.

M-A Ruel 2014/09/18 22:42:46 compatibility

self.stderr = stderr

self.cwd = cwd

« no previous file with comments | « no previous file | no next file » | no next file with comments »