Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 58293003: ash: Add VLOG(1) to UserActivityDetector. (Closed)

Created:
7 years, 1 month ago by Daniel Erat
Modified:
7 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

ash: Add VLOG(1) to UserActivityDetector. Add a VLOG(1) message containing event details to UserActivityDetector. This makes it easier to debug unexpected user activity, which we've seen in the past. BUG=none TBR=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M ash/wm/user_activity_detector.cc View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Erat
7 years, 1 month ago (2013-11-04 20:27:16 UTC) #1
Daniel Erat
(got LGTM from Nikita over email, but it looks like chromium-reviews wasn't cc-ed)
7 years, 1 month ago (2013-11-04 20:54:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-04 21:20:31 UTC) #3
Daniel Erat
7 years, 1 month ago (2013-11-04 21:30:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/58293003/1
7 years, 1 month ago (2013-11-04 21:37:42 UTC) #5
Nikita (slow)
lgtm
7 years, 1 month ago (2013-11-04 22:45:29 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=93541
7 years, 1 month ago (2013-11-05 01:23:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/58293003/1
7 years, 1 month ago (2013-11-05 04:03:56 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 14:32:53 UTC) #9
Message was sent while issue was closed.
Change committed as 232985

Powered by Google App Engine
This is Rietveld 408576698