third_party/polymer/reproduce.sh - Issue 582873003: Polymer elements added to third_party/polymer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/polymer/reproduce.sh

Issue 582873003: Polymer elements added to third_party/polymer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/bin/bash

	2

	3 # Copyright 2014 The Chromium Authors. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 set -e

	8

	9 rm -rf components
	Lei Zhang 2014/09/23 01:02:57 Erm, this depends on your CWD. If you're in src/, Erm, this depends on your CWD. If you're in src/, you just nuked src/components... I would make this script do a dry run by default and just print out what it would delete/chomd. Only carry out the operations if ran with --really-do-this. dzhioev (left Google) 2014/09/23 08:43:01 Fixed, scripts makes everything in its own directo Show quoted text On 2014/09/23 01:02:57, Lei Zhang wrote: > Erm, this depends on your CWD. If you're in src/, you just nuked > src/components... > Fixed, scripts makes everything in its own directory now. Show quoted text > I would make this script do a dry run by default and just print out what it > would delete/chomd. Only carry out the operations if ran with --really-do-this. It is not so easy, because actions made by commands depend of results of previous commands. For example, the command that removes empty directories from web-animations-js.
	10 bower install

	11 find components/web-animations-js/ -type f \
	Lei Zhang 2014/09/23 01:02:57 For each of these find commands, how many files ar For each of these find commands, how many files are actually affected. If it's not too long, perhaps you want to be explicit about it? Is the output of "bower install" always the same? It's a bit weird that this is called "reproduce.sh" but I worry this may not always produce the same output. dzhioev (left Google) 2014/09/23 08:43:01 ~ 200 files in web-animations-js and 12 files in c Show quoted text On 2014/09/23 01:02:57, Lei Zhang wrote: > For each of these find commands, how many files are actually affected. If it's > not too long, perhaps you want to be explicit about it? > ~ 200 files in web-animations-js and 12 files in core-list. I think find commands is more descriptive, then an explicit list. Show quoted text > Is the output of "bower install" always the same? It's a bit weird that this is > called "reproduce.sh" but I worry this may not always produce the same output. Yes, it is. I've stated exact versions for every package in bower.json and wrote presubmit script to be sure that we installed only dependencies listed in bower.json.
	12 -not \( -name web-animations.js -o \

	13 -name README.md -o \

	14 -name COPYING \) -delete

	15 find components/web-animations-js/ -type d -empty -delete

	16 find components/core-list -type f -exec chmod -x {} \;

OLD	NEW

« no previous file with comments | « third_party/polymer/polymer/polymer.js.map ('k') | ui/file_manager/file_manager/audio_player.html » ('j') | no next file with comments »