Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/gn/variables.cc

Issue 582863002: GN: Complete static libs can't depend on static libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add check for inherited static libraries as well Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 75172ecf4c64e445d4fa7e778fff204a7fade31a..de214efdad102a63f50be4d039333ec8ac365b22 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -375,7 +375,7 @@ const char kCompleteStaticLib_Help[] =
"complete_static_lib: [boolean] Links all deps into a static library.\n"
"\n"
" A static library normally doesn't include code from dependencies, but\n"
- " instead forward the static libraries and source sets in its deps up\n"
+ " instead forwards the static libraries and source sets in its deps up\n"
" the dependency chain until a linkable target (an executable or shared\n"
" library) is reached. The final linkable target only links each static\n"
" library once, even if it appears more than once in its dependency\n"
@@ -384,7 +384,10 @@ const char kCompleteStaticLib_Help[] =
" In some cases the static library might be the final desired output.\n"
" For example, you may be producing a static library for distribution to\n"
" third parties. In this case, the static library should include code\n"
- " for all dependencies in one complete package.\n"
+ " for all dependencies in one complete package. Since GN does not unpack\n"
+ " static libraries to forward their contents up the dependency chain,\n"
+ " it is an error for complete static libraries to depend on other static\n"
+ " libraries.\n"
"\n"
"Example\n"
"\n"
« no previous file with comments | « tools/gn/target_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698