Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 582793002: Telemetry: Use the leftmost argument to find the test to parse flags. (Closed)

Created:
6 years, 3 months ago by jbroman
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Use the leftmost argument to find the test to parse flags. Previously it would check all of the arguments, and use the last test found. This is causes problems as different tests can be used to create the parser and accepts the parsed flags. SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark or run_gpu_test.py appear, this is likely the cause. It is safe to revert. BUG=413334 Committed: https://crrev.com/5afe5a61f03743bd523dae66f662ad773f8befb9 Cr-Commit-Position: refs/heads/master@{#295738}

Patch Set 1 #

Patch Set 2 : only check the first argument #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tools/telemetry/telemetry/test_runner.py View 1 2 chunks +14 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
jbroman
This is an alternative fix for bug 413334. https://codereview.chromium.org/560153004/ broke WebRTC, and after discussion with ...
6 years, 3 months ago (2014-09-18 19:17:27 UTC) #2
nednguyen
LGTM Thanks for fixing this! Maybe worth adding in the description that sheriff can revert ...
6 years, 3 months ago (2014-09-19 15:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582793002/20001
6 years, 3 months ago (2014-09-19 17:19:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 50635a15c0b897991d34d0fb73633a8effb2f23e
6 years, 3 months ago (2014-09-19 18:11:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5afe5a61f03743bd523dae66f662ad773f8befb9 Cr-Commit-Position: refs/heads/master@{#295738}
6 years, 3 months ago (2014-09-19 18:12:36 UTC) #7
jbroman
6 years, 3 months ago (2014-09-19 19:31:15 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/584023003/ by jbroman@chromium.org.

The reason for reverting is: Broke Android debug gpu bot:
http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%...

This bot relies on being able to supply some flags before the test name; it
runs:
content/test/gpu/run_gpu_test.py --browser=android-content-shell
webgl_conformance --webgl-conformance-version=1.0.1.

Powered by Google App Engine
This is Rietveld 408576698