Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 582783003: fix flaky autofill test (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fix flaky autofill test BUG=412968 Committed: https://crrev.com/c72223f0644fbfed6e391f3ce50664df254c0f74 Cr-Commit-Position: refs/heads/master@{#295512}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 2 chunks +7 lines, -7 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Evan Stade
https://codereview.chromium.org/582783003/diff/1/components/autofill/core/browser/webdata/web_data_service_unittest.cc File components/autofill/core/browser/webdata/web_data_service_unittest.cc (right): https://codereview.chromium.org/582783003/diff/1/components/autofill/core/browser/webdata/web_data_service_unittest.cc#newcode376 components/autofill/core/browser/webdata/web_data_service_unittest.cc:376: I was able to reproduce the flake consistently by ...
6 years, 3 months ago (2014-09-18 17:51:34 UTC) #2
Dan Beam
lgtm
6 years, 3 months ago (2014-09-18 18:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582783003/1
6 years, 3 months ago (2014-09-18 18:03:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as cb13406fefee0472a86fe3d57f1ac83b7ae8ff1e
6 years, 3 months ago (2014-09-18 19:02:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:03:18 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c72223f0644fbfed6e391f3ce50664df254c0f74
Cr-Commit-Position: refs/heads/master@{#295512}

Powered by Google App Engine
This is Rietveld 408576698