Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 582783002: GN Help text typo fix in dotfile text. (Closed)

Created:
6 years, 3 months ago by scheib
Modified:
6 years, 3 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Project:
chromium
Visibility:
Public.

Description

GN Help text typo fix in dotfile text. Committed: https://crrev.com/2315800d9d2aa41906223442de1f95de0b7a4a87 Cr-Commit-Position: refs/heads/master@{#295559}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/setup.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
scheib
6 years, 3 months ago (2014-09-18 16:50:15 UTC) #2
tfarina
lgtm https://codereview.chromium.org/582783002/diff/1/tools/gn/setup.cc File tools/gn/setup.cc (right): https://codereview.chromium.org/582783002/diff/1/tools/gn/setup.cc#newcode69 tools/gn/setup.cc:69: " above), the file will first be looked ...
6 years, 3 months ago (2014-09-18 17:13:07 UTC) #4
brettw
lgtm
6 years, 3 months ago (2014-09-18 18:08:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582783002/1
6 years, 3 months ago (2014-09-18 19:48:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9756c587729a2cc75d84569a3bb2e559cc0186ef
6 years, 3 months ago (2014-09-18 21:43:26 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:44:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2315800d9d2aa41906223442de1f95de0b7a4a87
Cr-Commit-Position: refs/heads/master@{#295559}

Powered by Google App Engine
This is Rietveld 408576698