Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html

Issue 582733003: [CSSGridLayout] Pass the valid tracks for |tracksForGrowAboveMaxBreadth| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Build fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html b/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html
index b85aaa4a26f644cff28e89674ad07d15d9c37d0e..68f9e5e27cec11275294237faf562c8c2cea2b07 100644
--- a/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html
+++ b/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html
@@ -41,6 +41,12 @@
.gridMaxContentAndMaxContentFixed {
grid-template-columns: max-content minmax(max-content, 35px);
}
+ .gridMinContentFixedAndFixedFixedAndAuto {
+ grid-template-columns: minmax(min-content, 20px) minmax(20px, 30px) auto;
+ }
+ .gridAutoAndFixedFixedAndMaxContentFixed {
+ grid-template-columns: auto minmax(20px, 30px) minmax(max-content, 20px);
+ }
</style>
<script src="../../resources/js-test.js"></script>
@@ -260,6 +266,35 @@
<div class="firstRowSecondColumn">XXXXXXX</div>
</div>
+<!-- The next four force the grid to grow only a particular subset of tracks above the limits -->
+<div class="constrainedContainer">
+ <div class="grid gridMinContentFixedAndAuto" id="gridMinContentFixedAndAutoAboveLimits">
+ <div class="firstRowBothColumn">XXXX XXXX</div>
+ <div class="firstRowBothColumn">XXXXXXXXXXX</div>
+ </div>
+</div>
+
+<div class="constrainedContainer">
+ <div class="grid gridMaxContentFixedAndAuto" id="gridMaxContentFixedAndAutoAboveLimits">
+ <div class="firstRowBothColumn">XXXX XXXX</div>
+ <div class="firstRowBothColumn">XXXXXXXXXXXXXXX</div>
+ </div>
+</div>
+
+<div class="constrainedContainer">
+ <div class="grid gridMinContentFixedAndFixedFixedAndAuto" id="gridMinContentFixedAndFixedFixedAndAuto">
+ <div class="firstRowBothColumn">XXXX XXXX</div>
+ <div class="firstRowBothColumn">XXXXXXXXXX</div>
+ </div>
+</div>
+
+<div class="constrainedContainer">
+ <div class="grid gridAutoAndFixedFixedAndMaxContentFixed" id="gridAutoAndFixedFixedAndMaxContentFixed">
+ <div class="firstRowBothColumn">XXXX XXXX</div>
+ <div class="firstRowBothColumn">XXXXXXXXXXXXXXX</div>
+ </div>
+</div>
+
<script>
function testGridColumnsValues(id, computedColumnValue)
{
@@ -308,6 +343,13 @@
testGridColumnsValues("gridAutoMaxContentUnsorted", "0px 90px");
testGridColumnsValues("gridMaxContentAndMinContentFixedUnsorted", "55px 40px");
testGridColumnsValues("gridMaxContentAndMaxContentFixedUnsorted", "75px 70px");
+
+ debug("");
+ debug("Check that only a subset of tracks grow above track limits.");
+ testGridColumnsValues("gridMinContentFixedAndAutoAboveLimits", "15px 95px");
+ testGridColumnsValues("gridMaxContentFixedAndAutoAboveLimits", "65px 85px");
+ testGridColumnsValues("gridMinContentFixedAndFixedFixedAndAuto", "20px 20px 60px");
+ testGridColumnsValues("gridAutoAndFixedFixedAndMaxContentFixed", "40px 20px 90px");
</script>
</body>
</html>
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698