Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/rendering/style/GridTrackSize.h

Issue 582733003: [CSSGridLayout] Pass the valid tracks for |tracksForGrowAboveMaxBreadth| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 bool isPercentage() const { return m_type == LengthTrackSizing && length().i sLength() && length().length().isPercent(); } 99 bool isPercentage() const { return m_type == LengthTrackSizing && length().i sLength() && length().length().isPercent(); }
100 100
101 bool operator==(const GridTrackSize& other) const 101 bool operator==(const GridTrackSize& other) const
102 { 102 {
103 return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBr eadth && m_maxTrackBreadth == other.m_maxTrackBreadth; 103 return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBr eadth && m_maxTrackBreadth == other.m_maxTrackBreadth;
104 } 104 }
105 105
106 void cacheMinMaxTrackBreadthTypes() 106 void cacheMinMaxTrackBreadthTypes()
107 { 107 {
108 bool minTrackBreadthIsMinContent = minTrackBreadth().isLength() && minTr ackBreadth().length().isMinContent();
108 m_minTrackBreadthIsMaxContent = minTrackBreadth().isLength() && minTrack Breadth().length().isMaxContent(); 109 m_minTrackBreadthIsMaxContent = minTrackBreadth().isLength() && minTrack Breadth().length().isMaxContent();
109 m_minTrackBreadthIsMinOrMaxContent = m_minTrackBreadthIsMaxContent || (m inTrackBreadth().isLength() && minTrackBreadth().length().isMinContent()); 110 m_minTrackBreadthIsMinOrMaxContent = m_minTrackBreadthIsMaxContent || mi nTrackBreadthIsMinContent;
110 m_maxTrackBreadthIsMaxContent = maxTrackBreadth().isLength() && maxTrack Breadth().length().isMaxContent(); 111 m_maxTrackBreadthIsMaxContent = maxTrackBreadth().isLength() && maxTrack Breadth().length().isMaxContent();
111 m_maxTrackBreadthIsMinOrMaxContent = m_maxTrackBreadthIsMaxContent || (m axTrackBreadth().isLength() && maxTrackBreadth().length().isMinContent()); 112 m_maxTrackBreadthIsMinOrMaxContent = m_maxTrackBreadthIsMaxContent || (m axTrackBreadth().isLength() && maxTrackBreadth().length().isMinContent());
113 m_minTrackBreadthIsMinContentAndMaxTrackBreadthIsMinOrMaxContent = minTr ackBreadthIsMinContent && m_maxTrackBreadthIsMinOrMaxContent;
Julien - ping for review 2014/09/30 17:36:57 It seems like we should store "lower-level informa
svillar 2014/10/01 07:48:57 Yeah, that's actually what I'm partially doing by
112 } 114 }
113 115
114 bool hasMinOrMaxContentMinTrackBreadth() const { return m_minTrackBreadthIsM inOrMaxContent; } 116 bool hasMinOrMaxContentMinTrackBreadth() const { return m_minTrackBreadthIsM inOrMaxContent; }
115 bool hasMaxContentMinTrackBreadth() const { return m_minTrackBreadthIsMaxCon tent; } 117 bool hasMaxContentMinTrackBreadth() const { return m_minTrackBreadthIsMaxCon tent; }
116 bool hasMinOrMaxContentMaxTrackBreadth() const { return m_maxTrackBreadthIsM inOrMaxContent; } 118 bool hasMinOrMaxContentMaxTrackBreadth() const { return m_maxTrackBreadthIsM inOrMaxContent; }
117 bool hasMaxContentMaxTrackBreadth() const { return m_maxTrackBreadthIsMaxCon tent; } 119 bool hasMaxContentMaxTrackBreadth() const { return m_maxTrackBreadthIsMaxCon tent; }
120 bool hasMinContentMinTrackBreadthAndMinOrMaxContentMaxTrackBreadth() const { return m_minTrackBreadthIsMinContentAndMaxTrackBreadthIsMinOrMaxContent; }
121 bool hasMaxContentMinTrackBreadthAndMaxContentMaxTrackBreadth() const { retu rn m_minTrackBreadthIsMaxContent && m_maxTrackBreadthIsMaxContent; }
118 122
119 private: 123 private:
120 GridTrackSizeType m_type; 124 GridTrackSizeType m_type;
121 GridLength m_minTrackBreadth; 125 GridLength m_minTrackBreadth;
122 GridLength m_maxTrackBreadth; 126 GridLength m_maxTrackBreadth;
123 bool m_minTrackBreadthIsMinOrMaxContent; 127 bool m_minTrackBreadthIsMinOrMaxContent;
124 bool m_minTrackBreadthIsMaxContent; 128 bool m_minTrackBreadthIsMaxContent;
125 bool m_maxTrackBreadthIsMinOrMaxContent; 129 bool m_maxTrackBreadthIsMinOrMaxContent;
126 bool m_maxTrackBreadthIsMaxContent; 130 bool m_maxTrackBreadthIsMaxContent;
131 bool m_minTrackBreadthIsMinContentAndMaxTrackBreadthIsMinOrMaxContent;
127 }; 132 };
128 133
129 } // namespace blink 134 } // namespace blink
130 135
131 #endif // GridTrackSize_h 136 #endif // GridTrackSize_h
OLDNEW
« Source/core/rendering/RenderGrid.cpp ('K') | « Source/core/rendering/RenderGrid.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698