[turbofan] IA: Float64ToUint32 supports mem operand

src/compiler/ia32/code-generator-ia32.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties-inl.h"
@@ skipping 284 matching lines @@
       __ fstp_d(Operand(esp, 0));
       __ movsd(i.OutputDoubleRegister(), Operand(esp, 0));
       __ add(esp, Immediate(kDoubleSize));
       break;
     }
     case kSSEFloat64ToInt32:
       __ cvttsd2si(i.OutputRegister(), i.InputOperand(0));
       break;
     case kSSEFloat64ToUint32: {
       XMMRegister scratch = xmm0;
+      Label done;
       __ Move(scratch, -2147483648.0);
-      // TODO(turbofan): IA32 SSE subsd() should take an operand.
-      __ addsd(scratch, i.InputDoubleRegister(0));
+      __ addsd(scratch, i.InputOperand(0));
       __ cvttsd2si(i.OutputRegister(), scratch);
       __ add(i.OutputRegister(), Immediate(0x80000000));
+      __ j(not_carry, &done, Label::kNear);

[titzer, 2014/09/18 14:03:06]

What does this extra condition here check?

Note that this the implementation of ChangeFloat64ToUint32, which explicitly
assumes that all of its inputs lie in the range [0...2^32-1] and are integers.

[Weiliang, 2014/09/18 14:11:01]

cvttsd2si truncates the result by rounding toward zero. So when changing the
range from [0...2^32-1] to [-2^31, 2^31-1], we need to compensate the result.

+      __ cvtsi2sd(scratch, i.OutputRegister());
+      __ ucomisd(scratch, i.InputOperand(0));
+      __ j(equal, &done, Label::kNear);
+      __ sub(i.OutputRegister(), Immediate(1));
+      __ bind(&done);
       break;
     }
     case kSSEInt32ToFloat64:
       __ cvtsi2sd(i.OutputDoubleRegister(), i.InputOperand(0));
       break;
     case kSSEUint32ToFloat64:
       // TODO(turbofan): IA32 SSE LoadUint32() should take an operand.
       __ LoadUint32(i.OutputDoubleRegister(), i.InputRegister(0));
       break;
     case kIA32Movsxbl:
@@ skipping 625 matching lines @@
 }
 
 
 void CodeGenerator::AddNopForSmiCodeInlining() { __ nop(); }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8