Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 582633002: Fix WeakPtrFactory member placement (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
Reviewers:
jam, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member placement Changing in the intialization order of WeakPtrFactory in src/chrome/browser module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/dfefffa1cd3d8de20392e55bb66168c1505312d5 Cr-Commit-Position: refs/heads/master@{#296007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
anujsharma
PTAL
6 years, 3 months ago (2014-09-18 09:05:52 UTC) #2
nasko
lgtm
6 years, 3 months ago (2014-09-22 14:02:03 UTC) #4
anujsharma
On 2014/09/22 14:02:03, nasko wrote: > lgtm Thanks nasko for lgtm.
6 years, 3 months ago (2014-09-22 16:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582633002/1
6 years, 3 months ago (2014-09-22 16:29:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as e045f39c556c96a367d8946d6b3b522018d6aab5
6 years, 3 months ago (2014-09-22 17:42:13 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 17:42:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfefffa1cd3d8de20392e55bb66168c1505312d5
Cr-Commit-Position: refs/heads/master@{#296007}

Powered by Google App Engine
This is Rietveld 408576698