Fix URLRequest pepper unit test

Fix URLRequest pepper unit test

This patch creates new URLLoaderResource objects for each request
since those objects can't be reused.

Calling Open() on an instance of URLLoaderResource requires that mode_
is set to MODE_WAITING_TO_OPEN. After Open() has been called mode_
will never reach that state again.

BUG=None

Committed: https://crrev.com/3d0670895e15c8e913d8d14322d3eefd9693b92d
Cr-Commit-Position: refs/heads/master@{#296155}

[landell, 2014-09-18 08:05:31]

landell@opera.com changed reviewers:
+ bbudge@chromium.org, dmichael@chromium.org, polina@google.com

[landell, 2014-09-18 08:09:31]

The addressed issue manifests itself when running the tests AppendDataToBody and
AppendFileToBody after each other, e.g. from the test plugin. I don't think this
is a problem when running the browser gtests since then, these tests are run
separately AFAICT.

@reviewers: Does this patch seems reasonable to you?

[dmichael (off chromium), 2014-09-19 16:05:12]

dmichael@chromium.org changed reviewers:
- polina@google.com

[dmichael (off chromium), 2014-09-19 16:05:12]

A couple of nits, o/w lgtm.

Thanks for catching that.

https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request.cc
File ppapi/tests/test_url_request.cc (right):

https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request...
ppapi/tests/test_url_request.cc:108: return "Failed to create URLLoader";
ASSERT_NE(kInvalidResource, url_loader);
?

https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request...
ppapi/tests/test_url_request.cc:299: return "Failed to create URLLoader";
ditto

[landell, 2014-09-22 08:51:30]

On 2014/09/19 16:05:12, dmichael wrote:
> A couple of nits, o/w lgtm.
> 
> Thanks for catching that.
> 
>
https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request.cc
> File ppapi/tests/test_url_request.cc (right):
> 
>
https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request...
> ppapi/tests/test_url_request.cc:108: return "Failed to create URLLoader";
> ASSERT_NE(kInvalidResource, url_loader);
> ?
> 
>
https://codereview.chromium.org/582623002/diff/1/ppapi/tests/test_url_request...
> ppapi/tests/test_url_request.cc:299: return "Failed to create URLLoader";
> ditto

Fixed these issues now. Don't know if a second lgtm is needed. Anyway, I will
allow a day for comments before landing this.

[dmichael (off chromium), 2014-09-22 15:42:28]

lgtm

[dmichael (off chromium), 2014-09-22 15:43:59]

Second lgtm is usually not needed for nits like this. If you end up with more
extensive changes than your reviewer asked for, you should definitely ask for
another review before landing.

In this case, the one lgtm was sufficient. Thanks again!

[landell, 2014-09-23 07:10:46]

The CQ bit was checked by landell@opera.com

[commit-bot: I haz the power, 2014-09-23 07:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582623002/20001

[commit-bot: I haz the power, 2014-09-23 07:55:48]

Committed patchset #2 (id:20001) as 034d9c19cacff42228a3eb2f0ae4d6b9a51494ab

[commit-bot: I haz the power, 2014-09-23 07:56:26]

Patchset 2 (id:??) landed as
https://crrev.com/3d0670895e15c8e913d8d14322d3eefd9693b92d
Cr-Commit-Position: refs/heads/master@{#296155}