Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Issue 582583003: Drop -fno-slp-vectorize from the Clang build (Closed)

Created:
6 years, 3 months ago by hans
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Drop -fno-slp-vectorize from the Clang build http://llvm.org/PR20354 was fixed and rolled into Chromium in the latest Clang roll. BUG=none Committed: https://crrev.com/5926b3d223f5c183b3341a01b522875aceae2ed9 Cr-Commit-Position: refs/heads/master@{#295564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hans
Since the Clang roll has been in for a day, maybe it's time to drop ...
6 years, 3 months ago (2014-09-18 16:49:07 UTC) #2
Nico
lgtm with green trybots (ScrollOffsetAnimationCurveTest.Duration in particular is the test that failed last time)
6 years, 3 months ago (2014-09-18 17:19:38 UTC) #3
hans
On 2014/09/18 17:19:38, Nico (hiding) wrote: > lgtm with green trybots (ScrollOffsetAnimationCurveTest.Duration in particular > ...
6 years, 3 months ago (2014-09-18 20:18:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582583003/1
6 years, 3 months ago (2014-09-18 20:19:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e2b1af5aaaef8db141c4603f4dab474472322b40
6 years, 3 months ago (2014-09-18 21:47:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5926b3d223f5c183b3341a01b522875aceae2ed9 Cr-Commit-Position: refs/heads/master@{#295564}
6 years, 3 months ago (2014-09-18 21:49:09 UTC) #8
Nico
Sorry, the commit message reminded me that some .gn file should get the same change…
6 years, 3 months ago (2014-09-18 21:52:49 UTC) #9
hans
6 years, 3 months ago (2014-09-18 23:35:22 UTC) #10
Message was sent while issue was closed.
On 2014/09/18 21:52:49, Nico (hiding) wrote:
> Sorry, the commit message reminded me that some .gn file should get the same
> change…

I'm the one who should have remembered in the first place. Fix:
https://codereview.chromium.org/585693002

Powered by Google App Engine
This is Rietveld 408576698