Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 582583002: Change the OOP PDF plugin to use BrowserPlugin mime type handling. (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change the OOP PDF plugin to use BrowserPlugin mime type handling. This changes OOP PDF to use BrowserPlugin which allows it to be loaded without navigating to the extension page. BUG=303491 Committed: https://crrev.com/5fa52aea4b8a022c3bfc7323b33fca84fd76b8ab Cr-Commit-Position: refs/heads/master@{#295641}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -50 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/background.js View 1 chunk +46 lines, -16 lines 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/pdf/main.js View 1 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 6 chunks +6 lines, -32 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
6 years, 3 months ago (2014-09-18 04:58:56 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-18 21:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582583002/1
6 years, 3 months ago (2014-09-18 21:35:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/10303)
6 years, 3 months ago (2014-09-18 21:59:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582583002/20001
6 years, 3 months ago (2014-09-19 00:54:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d4ff9e348a6f32bccef0a33e89836839f109e273
6 years, 3 months ago (2014-09-19 01:51:59 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 01:52:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fa52aea4b8a022c3bfc7323b33fca84fd76b8ab
Cr-Commit-Position: refs/heads/master@{#295641}

Powered by Google App Engine
This is Rietveld 408576698