Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Issue 582543002: Fix refresh rate query for internal monitors (Closed)

Created:
6 years, 3 months ago by marcheu
Modified:
6 years ago
Reviewers:
oshima, piman
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix refresh rate query for internal monitors GetSelectedModeForDisplayId doesn't work for internal displays. This results in failing the query, and falling back to refresh rate approximation in the scheduler. To fix this, we use GetActiveModeForDisplayId which exists even on internal displays. This fixes the swap interval that the cc scheduler sees. BUG=chromium:415359 TEST=make a trace on pixel, look at interval_us, it is a constant 16677 now (before it was variable and inaccurate) Committed: https://crrev.com/1ad53a56f0872fe46103dcaa7f3a0199a825073e Cr-Commit-Position: refs/heads/master@{#295505}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gl/gl_surface_ozone.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
marcheu
6 years, 3 months ago (2014-09-18 01:12:14 UTC) #2
oshima
lgtm
6 years, 3 months ago (2014-09-18 05:12:34 UTC) #3
piman
lgtm
6 years, 3 months ago (2014-09-18 17:40:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582543002/1
6 years, 3 months ago (2014-09-18 17:44:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7f0a2e56a3e43c1fa8a95022223bb562793a891a
6 years, 3 months ago (2014-09-18 18:44:46 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:45:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ad53a56f0872fe46103dcaa7f3a0199a825073e
Cr-Commit-Position: refs/heads/master@{#295505}

Powered by Google App Engine
This is Rietveld 408576698