Translate: Fix broken UMA entries

Translate: Fix broken UMA entries

UMA reporting values are temporarily broken. This change will fix the
value and add a definition for the new item.

TEST=unit_tests
BUG=n/a

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232984

[Takashi Toyoshima, 2013-11-04 19:22:54]

PTAL.

[hajimehoshi, 2013-11-04 23:00:11]

lgtm

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ilya Sherman, 2013-11-05 00:04:59]

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_browser_metrics.h (right):

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_browser_metrics.h:27: // below.
It looks like this change will break the histogram; or else that previously
uploaded data to this histogram was incorrect.  Either way, your histogram will
now have mixed data, which is a pain to work with.  I'd strongly encourage you
rename the live histogram, and mark the old name as <obsolete> in
histograms.xml.

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_browser_metrics.h:40: // Insert new item
here.
nit: "new item" -> "new items"

[Takashi Toyoshima, 2013-11-05 00:18:27]

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_browser_metrics.h (right):

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_browser_metrics.h:27: // below.
Actually, it was already broken, and this change is going to revert the broken
order. Then,even so do you think that renaming is better?

Also I have one question. If I make a change against XML, does it affects to UMA
dashboard immediately? Does it affects to all dashboard results including old
one which were aggregated before the XML change?

[Ilya Sherman, 2013-11-05 00:20:57]

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_browser_metrics.h (right):

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_browser_metrics.h:27: // below.
On 2013/11/05 00:18:27, Takashi Toyoshima (chromium) wrote:
> Actually, it was already broken, and this change is going to revert the broken
> order. Then,even so do you think that renaming is better?

If it was already broken, then you already have polluted data that has been
uploaded to the server and that is reflected on the dashboard.  There will
always be clients stuck on the versions that had the broken logic, so the data
will be polluted forever from now on.  Hence, I do recommend renaming the
histogram and obsoleting the current name.

> Also I have one question. If I make a change against XML, does it affects to
UMA
> dashboard immediately? Does it affects to all dashboard results including old
> one which were aggregated before the XML change?

Yes, changes to the XML are picked up more or less immediately, and affect all
data, past, present, and future.

[Takashi Toyoshima, 2013-11-05 01:31:04]

Thanks.
I decided to rename it to v2.
PTAL.

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
File chrome/browser/translate/translate_browser_metrics.h (right):

https://chromiumcodereview.appspot.com/58253002/diff/1/chrome/browser/transla...
chrome/browser/translate/translate_browser_metrics.h:40: // Insert new item
here.
On 2013/11/05 00:04:59, Ilya Sherman wrote:
> nit: "new item" -> "new items"

Done.

[Ilya Sherman, 2013-11-05 01:43:19]

Thanks, LGTM.

https://chromiumcodereview.appspot.com/58253002/diff/90001/tools/metrics/hist...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/58253002/diff/90001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:18553: +    Deprecated as of 11/2013.
Optional nit: Consider mentioning which histogram this was replaced by.

[Takashi Toyoshima, 2013-11-05 02:06:49]

https://chromiumcodereview.appspot.com/58253002/diff/90001/tools/metrics/hist...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/58253002/diff/90001/tools/metrics/hist...
tools/metrics/histograms/histograms.xml:18553: +    Deprecated as of 11/2013.
Good point.
Done!

[commit-bot: I haz the power, 2013-11-05 02:39:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/58253002/130001

[commit-bot: I haz the power, 2013-11-05 03:28:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/58253002/130001

[commit-bot: I haz the power, 2013-11-05 04:26:47]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 04:39:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/58253002/130001

[commit-bot: I haz the power, 2013-11-05 04:54:17]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 05:49:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/58253002/130001

[commit-bot: I haz the power, 2013-11-05 08:22:50]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 08:25:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/58253002/130001

[commit-bot: I haz the power, 2013-11-05 14:32:25]

Change committed as 232984