Enable accessibility testing for the bookmark browser test.

chrome/test/base/in_process_browser_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/in_process_browser_test.h"
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 17 matching lines @@
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/chrome_content_renderer_client.h"
+#include "chrome/test/base/accessibility_test_helper.h"
 #include "chrome/test/base/chrome_test_suite.h"
 #include "chrome/test/base/test_launcher_utils.h"
 #include "chrome/test/base/test_switches.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/os_crypt/os_crypt.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_launcher.h"
@@ skipping 61 matching lines @@
   CHECK(CalledOnValidThread());
   CHECK_EQ(browser->host_desktop_type(), allowed_desktop_);
 }
 
 }  // namespace
 
 InProcessBrowserTest::InProcessBrowserTest()
     : browser_(NULL),
       exit_when_last_browser_closes_(true),
       open_about_blank_on_browser_launch_(true),
-      multi_desktop_test_(false)
+      multi_desktop_test_(false),
+      run_accessibility_checks_(false)
 #if defined(OS_MACOSX)
       , autorelease_pool_(NULL)
 #endif  // OS_MACOSX
     {
 #if defined(OS_MACOSX)
   // TODO(phajdan.jr): Make browser_tests self-contained on Mac, remove this.
   // Before we run the browser, we have to hack the path to the exe to match
   // what it would be if Chrome was running, because it is used to fork renderer
   // processes, on Linux at least (failure to do so will cause a browser_test to
   // be run instead of a renderer).
@@ skipping 123 matching lines @@
 #endif
 
   // TODO(pkotwicz): Investigate if we can remove this switch.
   if (exit_when_last_browser_closes_)
     command_line->AppendSwitch(switches::kDisableZeroBrowsersOpenForTests);
 
   if (open_about_blank_on_browser_launch_ && command_line->GetArgs().empty())
     command_line->AppendArg(url::kAboutBlankURL);
 }
 
+void InProcessBrowserTest::RunAccessibilityChecks() {
+  // A failure here means it is not possible to test for accessibility and it

[Paweł Hajdan Jr., 2015/01/29 13:01:19]

nit: All the comments in this method seem to just repeat what the code
indicates. How about removing them?

[hcarmona, 2015/01/30 22:19:47]

Done.

+  // doesn't make sense to continue.
+  ASSERT_TRUE(browser());
+  auto tab_strip = browser()->tab_strip_model();
+  ASSERT_TRUE(tab_strip);
+  auto web_contents = tab_strip->GetActiveWebContents();
+  ASSERT_TRUE(web_contents);
+  auto focused_frame = web_contents->GetFocusedFrame();
+  ASSERT_TRUE(focused_frame);
+
+  AccessibilityTestHelper helper;
+  // Failing to load libraries or failing to run the test is fatal.
+  ASSERT_TRUE(helper.LoadLibrary(web_contents));
+  ASSERT_TRUE(helper.RunAccessibilityTest(focused_frame));
+
+  // Failing the test is not fatal and we should continue to report other
+  // failures.
+  EXPECT_EQ(AccessibilityTestHelper::kExpectedResults,
+            helper.accessibility_message());
+}
+
 bool InProcessBrowserTest::CreateUserDataDirectory() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   base::FilePath user_data_dir =
       command_line->GetSwitchValuePath(switches::kUserDataDir);
   if (user_data_dir.empty()) {
     if (temp_user_data_dir_.CreateUniqueTempDir() &&
         temp_user_data_dir_.IsValid()) {
       user_data_dir = temp_user_data_dir_.path();
     } else {
       LOG(ERROR) << "Could not create temporary user data directory \""
@@ skipping 85 matching lines @@
       content::NOTIFICATION_LOAD_STOP,
       content::NotificationService::AllSources());
   chrome::AddSelectedTabWithURL(browser,
                                 GURL(url::kAboutBlankURL),
                                 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
   observer.Wait();
 
   browser->window()->Show();
 }
 
+void InProcessBrowserTest::DisableAccessibilityChecks() {
+  run_accessibility_checks_for_test_case_ = false;
+}
+
+void InProcessBrowserTest::EnableAccessibilityChecks() {
+  run_accessibility_checks_for_test_case_ = true;
+}
+
 #if !defined(OS_MACOSX)
 base::CommandLine InProcessBrowserTest::GetCommandLineForRelaunch() {
   base::CommandLine new_command_line(
       base::CommandLine::ForCurrentProcess()->GetProgram());
   base::CommandLine::SwitchMap switches =
       base::CommandLine::ForCurrentProcess()->GetSwitches();
   switches.erase(switches::kUserDataDir);
   switches.erase(content::kSingleProcessTestsFlag);
   switches.erase(switches::kSingleProcess);
   new_command_line.AppendSwitch(content::kLaunchAsBrowser);
@@ skipping 54 matching lines @@
 
   // Pump any pending events that were created as a result of creating a
   // browser.
   content::RunAllPendingInMessageLoop();
 
   SetUpOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
+  // run_accessibility_checks_for_test_case_ must be set BEFORE calling
+  // RunTestOnMainThread because a test has the option to override the decision
+  // to run accessibility tests in the test body.
+  run_accessibility_checks_for_test_case_ = run_accessibility_checks_;
+
   if (!HasFatalFailure())
     RunTestOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
+  // This will be true if
+  //   - The current test called EnableAccessibilityChecks
+  //   - The current test did NOT call DisableAccessibilityChecks and
+  //     run_accessibility_checks_ is true.
+  if (run_accessibility_checks_for_test_case_)
+    RunAccessibilityChecks();
+
   // Invoke cleanup and quit even if there are failures. This is similar to
   // gtest in that it invokes TearDown even if Setup fails.
   TearDownOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
   // Sometimes tests leave Quit tasks in the MessageLoop (for shame), so let's
   // run all pending messages here to avoid preempting the QuitBrowsers tasks.
   // TODO(jbates) Once crbug.com/134753 is fixed, this can be removed because it
@@ skipping 30 matching lines @@
   // On the Mac, this eventually reaches
   // -[BrowserWindowController windowWillClose:], which will post a deferred
   // -autorelease on itself to ultimately destroy the Browser object. The line
   // below is necessary to pump these pending messages to ensure all Browsers
   // get deleted.
   content::RunAllPendingInMessageLoop();
   delete autorelease_pool_;
   autorelease_pool_ = NULL;
 #endif
 }