Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 582413002: Make ONCCertificateImporter async. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva, eroman
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, eroman, davemoore+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ONCCertificateImporter async. This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. Now, the import itself is asychronous and calls back on completion. While there, this also removes the GMock of the importer. This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925 refs/heads/master@{#295534} with the fixed destruction order in ONCCertificateImporterImplTest. The fix was reviewed in https://codereview.chromium.org/589443002/ TBR=eroman@chromium.org BUG=413219 Committed: https://crrev.com/3b4ba221657f6b27e2156818bc445c885d87fc0e Cr-Commit-Position: refs/heads/master@{#295687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -324 lines) Patch
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 18 chunks +92 lines, -74 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 4 chunks +16 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +47 lines, -26 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D chromeos/network/onc/mock_certificate_importer.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chromeos/network/onc/mock_certificate_importer.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer.h View 2 chunks +17 lines, -11 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.h View 4 chunks +38 lines, -27 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 13 chunks +117 lines, -79 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 12 chunks +62 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pneubeck (no reviews)
Reland with the fix reviewed already by Joao.
6 years, 3 months ago (2014-09-19 10:07:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582413002/1
6 years, 3 months ago (2014-09-19 10:07:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 203906e1d566f1eb96439fa83dd2ec7393a62715
6 years, 3 months ago (2014-09-19 11:05:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b4ba221657f6b27e2156818bc445c885d87fc0e Cr-Commit-Position: refs/heads/master@{#295687}
6 years, 3 months ago (2014-09-19 11:06:46 UTC) #6
eugenis
6 years, 3 months ago (2014-09-19 14:30:52 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/584923002/ by eugenis@chromium.org.

The reason for reverting is: Use-after-free.
https://code.google.com/p/chromium/issues/detail?id=415916.

Powered by Google App Engine
This is Rietveld 408576698