GN build: Prescribe -Wno-header-guard for direct dependents of libssl.

GN build: Prescribe -Wno-header-guard for direct dependents of libssl.

This is required to workaround typo in the guard macro of secmod.h. See details in bug.

BUG=415498
Committed: https://crrev.com/78f3331bfec0cf4db351c806a40517e62d386887
Cr-Commit-Position: refs/heads/master@{#297754}

[engedy, 2014-09-19 09:50:02]

engedy@chromium.org changed reviewers:
+ brettw@chromium.org, thestig@chromium.org

[engedy, 2014-09-19 09:50:02]

Brett, Lei, please take a look.

[brettw, 2014-09-19 19:26:00]

lgtm

[engedy, 2014-09-25 12:36:45]

On 2014/09/19 19:26:00, brettw wrote:
> lgtm

Lei, friendly ping.

[Lei Zhang, 2014-09-25 18:12:58]

On 2014/09/25 12:36:45, engedy wrote:
> On 2014/09/19 19:26:00, brettw wrote:
> > lgtm
> 
> Lei, friendly ping.

I didn't know you were waiting for me. lgtm.

[engedy, 2014-09-29 09:05:53]

engedy@chromium.org changed reviewers:
+ wtc@chromium.org

[engedy, 2014-09-29 09:05:53]

@Wan-Teh, could you PTAL for Owner's approval?

[wtc, 2014-09-29 17:35:45]

Review comments on patch set 1:

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:140: "-Wno-header-guard",

The -Wno-header-guard flag is already added here. Please find out why it isn't
working.

[brettw, 2014-09-29 17:42:28]

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:140: "-Wno-header-guard",
We should delete this one. The one above will also apply to direct dependents in
addition to this target, so covers more stuff.

[wtc, 2014-09-29 17:50:01]

Patch set 1 LGTM, with the change that brettw suggested.

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:136: "-Wno-incompatible-pointer-types",

This NSS bug was fixed in NSS 3.12.10. Chromium requires NSS 3.14.3 or later
now. So please don't copy this to the new config("ssl_config") section above.

If you have time, please remove this flag from this file and from
net/third_party/nss/ssl.gyp. If you don't want to complicate this CL, I will
take care of this.

[engedy, 2014-09-29 18:59:10]

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:136: "-Wno-incompatible-pointer-types",
On 2014/09/29 17:50:01, wtc wrote:
> 
> This NSS bug was fixed in NSS 3.12.10. Chromium requires NSS 3.14.3 or later
> now. So please don't copy this to the new config("ssl_config") section above.
> 
> If you have time, please remove this flag from this file and from
> net/third_party/nss/ssl.gyp. If you don't want to complicate this CL, I will
> take care of this.

Hmm, in my read, all signs point to that it was only fixed in 3.15.1, what I am
missing?

More specifically, according to [1], 3.12.10 still seems to contain the typo,
[2] says that the fix was slated for 3.15.1, and we are indeed using 3.14.5 for
Chrome branded builds (see [3,4]), and the compile error is still present.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=884072
[2]:
http://anonscm.debian.org/cgit/pkg-mozilla/nss.git/tree/mozilla/security/nss/...
[3]:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/installer/l...
[4]: https://packages.debian.org/source/wheezy/nss

[wtc, 2014-09-29 19:43:38]

Balazs: I answered your question below.

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:136: "-Wno-incompatible-pointer-types",

On 2014/09/29 18:59:10, engedy wrote:
> 
> Hmm, in my read, all signs point to that it was only fixed in 3.15.1, what I
am
> missing?

I was talking about the -Wno-incompatible-pointer-types flag, which is not part
of your CL. The NSS bug that -Wno-incompatible-pointer-types works around is
https://bugzilla.mozilla.org/show_bug.cgi?id=635778 , which is fixed in NSS
3.12.10.

Sorry about the confusion.

[engedy, 2014-09-30 18:15:30]

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:136: "-Wno-incompatible-pointer-types",
On 2014/09/29 19:43:38, wtc wrote:
> 
> On 2014/09/29 18:59:10, engedy wrote:
> > 
> > Hmm, in my read, all signs point to that it was only fixed in 3.15.1, what I
> am
> > missing?
> 
> I was talking about the -Wno-incompatible-pointer-types flag, which is not
part
> of your CL. The NSS bug that -Wno-incompatible-pointer-types works around is
> https://bugzilla.mozilla.org/show_bug.cgi?id=635778 , which is fixed in NSS
> 3.12.10.
> 
> Sorry about the confusion.

Ahh, my bad, sorry! I have prepared https://codereview.chromium.org/616093002/
to fix this.

https://codereview.chromium.org/582403002/diff/1/net/third_party/nss/ssl/BUIL...
net/third_party/nss/ssl/BUILD.gn:140: "-Wno-header-guard",
On 2014/09/29 17:42:28, brettw wrote:
> We should delete this one. The one above will also apply to direct dependents
in
> addition to this target, so covers more stuff.

Done.

[engedy, 2014-09-30 18:15:35]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-09-30 18:17:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582403002/20001

[commit-bot: I haz the power, 2014-09-30 18:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 18:30:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wtc, 2014-10-02 00:35:47]

Patch set 2 LGTM. I have taken care of the OWNERS file issue. I will click the
Commit box for you.

[wtc, 2014-10-02 00:35:50]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-10-02 00:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582403002/20001

[commit-bot: I haz the power, 2014-10-02 01:03:00]

Committed patchset #2 (id:20001) as 7e2e92a6c0eef750b1839960fead93beaaa1d654

[commit-bot: I haz the power, 2014-10-02 01:03:43]

Patchset 2 (id:??) landed as
https://crrev.com/78f3331bfec0cf4db351c806a40517e62d386887
Cr-Commit-Position: refs/heads/master@{#297754}