Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 582373003: Explicitely unlock screen orientation when navigating. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Explicitely unlock screen orientation when navigating. BUG=162827 Committed: https://crrev.com/348411101bef293f86b792c5f39598ce140c833b Cr-Commit-Position: refs/heads/master@{#295692}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-19 11:36:17 UTC) #2
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-19 12:14:00 UTC) #4
Peter Beverloo
It would be interesting to know how this works with history.replaceState or history.pushState, but that ...
6 years, 3 months ago (2014-09-19 12:18:05 UTC) #5
mlamouri (slow - plz ping)
On 2014/09/19 12:18:05, Peter Beverloo wrote: > It would be interesting to know how this ...
6 years, 3 months ago (2014-09-19 12:18:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582373003/20001
6 years, 3 months ago (2014-09-19 12:19:50 UTC) #8
mlamouri (slow - plz ping)
On 2014/09/19 12:18:36, Mounir Lamouri wrote: > On 2014/09/19 12:18:05, Peter Beverloo wrote: > > ...
6 years, 3 months ago (2014-09-19 12:29:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 686d0bd284f2640b353738d7eb746ae8c0386483
6 years, 3 months ago (2014-09-19 13:13:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 13:14:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/348411101bef293f86b792c5f39598ce140c833b
Cr-Commit-Position: refs/heads/master@{#295692}

Powered by Google App Engine
This is Rietveld 408576698