Issue 582373002: X87: When serializer is enalbed, we disable the X87 stack check to reduce the code size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 582373002: X87: When serializer is enalbed, we disable the X87 stack check to reduce the code size. (Closed)

Created:
6 years, 3 months ago by chunyang.dai

Modified:
6 years, 3 months ago

Reviewers:
Weiliang

CC:
v8-dev, danno

Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: When serializer is enalbed, we disable the X87 stack check to reduce the code size. The reason is that the big code size will leads to test-serialize test cases fail when debug mode and snapshot=off. BUG=

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/x87/macro-assembler-x87.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Weiliang

lgtm This is a workaround solution and we will revisit it in future.

6 years, 3 months ago (2014-09-19 09:23:03 UTC) #3

Committed as r24070

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages