Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 58233002: [Translate] Use the UIDelegate implementation of TranslationDeclined() (Closed)

Created:
7 years, 1 month ago by Miguel Garcia
Modified:
7 years, 1 month ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Visibility:
Public.

Description

[Translate] Use the UIDelegate implementation of TranslationDeclined() Now that the investigation is over we don't need the special code anymore. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233141

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Miguel Garcia
After my fix on the android side the crashes vanished so we can remove this ...
7 years, 1 month ago (2013-11-04 19:11:52 UTC) #1
hajimehoshi
lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
7 years, 1 month ago (2013-11-04 23:06:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/58233002/1
7 years, 1 month ago (2013-11-05 08:31:21 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 09:07:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/58233002/280001
7 years, 1 month ago (2013-11-05 13:24:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185046
7 years, 1 month ago (2013-11-05 15:29:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/58233002/280001
7 years, 1 month ago (2013-11-05 15:47:59 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=185175
7 years, 1 month ago (2013-11-05 18:33:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/58233002/280001
7 years, 1 month ago (2013-11-05 19:13:16 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 23:50:04 UTC) #10
Message was sent while issue was closed.
Change committed as 233141

Powered by Google App Engine
This is Rietveld 408576698