Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 582293002: Better handle failures in pipes in debian/build.sh (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Better handle failures in pipes in debian/build.sh - add -o pipefail - do not hide stderr BUG=none R=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/7a64b9aa4aa16d8bbded3ac531c614473caab375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/installer/linux/debian/build.sh View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
6 years, 3 months ago (2014-09-19 01:07:09 UTC) #2
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-19 01:23:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a64b9aa4aa16d8bbded3ac531c614473caab375 Cr-Commit-Position: refs/heads/master@{#296117}
6 years, 3 months ago (2014-09-23 01:09:06 UTC) #4
Paweł Hajdan Jr.
6 years, 3 months ago (2014-09-23 01:09:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 7a64b9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698