Cast: Reduce the size of stats

media/cast/logging/stats_event_subscriber.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/logging/stats_event_subscriber.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
@@ skipping 47 matching lines @@
 void StatsEventSubscriber::SimpleHistogram::Reset() {
   buckets_.assign(buckets_.size(), 0);
 }
 
 scoped_ptr<base::ListValue>
 StatsEventSubscriber::SimpleHistogram::GetHistogram() const {
   scoped_ptr<base::ListValue> histo(new base::ListValue);
 
   scoped_ptr<base::DictionaryValue> bucket(new base::DictionaryValue);
 
-  bucket->SetString("bucket", base::StringPrintf("< %" PRId64, min_));
-  bucket->SetInteger("count", buckets_.front());
+  bucket->SetInteger(base::StringPrintf("< %" PRId64, min_),

[imcheng, 2014/09/19 20:48:14]

I think you can also get rid of the spaces between the signs and numbers, that
would save you even more space and makes parsing easier.

[Alpha Left Google, 2014/09/19 20:57:55]

Done.

+                     buckets_.front());
   histo->Append(bucket.release());
 
-  for (size_t i = 1; i < buckets_.size() - 1; i++) {
+  size_t index = 1;
+  while (index < buckets_.size() - 1) {
     bucket.reset(new base::DictionaryValue);
+    size_t end_index = index;
 
-    int64 lower = min_ + (i - 1) * width_;
-    int64 upper = lower + width_ - 1;
-    bucket->SetString(
-        "bucket", base::StringPrintf("%" PRId64 " - %" PRId64, lower, upper));
-    bucket->SetInteger("count", buckets_[i]);
+    // Find as many consecutive zero buckets as possible.
+    if (!buckets_[index]) {

[imcheng, 2014/09/19 20:52:33]

nit: prefer explicitly checking != 0.

[Alpha Left Google, 2014/09/19 20:57:55]

Done.

+      while (end_index + 2 < buckets_.size() && !buckets_[end_index + 1])

[imcheng, 2014/09/19 20:52:33]

ditto

[Alpha Left Google, 2014/09/19 20:57:55]

Done.

+        ++end_index;
+    }
+    int64 lower = min_ + (index - 1) * width_;
+    int64 upper = min_ + end_index * width_ - 1;

[imcheng, 2014/09/19 20:52:33]

Shouldn't this be min_ + (end_index - index) * width_ - 1; ?

[imcheng, 2014/09/19 20:53:56]

Never mind, I misread this.

+    bucket->SetInteger(
+        base::StringPrintf("%" PRId64 " - %" PRId64, lower, upper),
+        buckets_[index]);
+    index = end_index + 1;
     histo->Append(bucket.release());
   }
 
   bucket.reset(new base::DictionaryValue);
-
-  bucket->SetString("bucket", base::StringPrintf(">= %" PRId64, max_));
-  bucket->SetInteger("count", buckets_.back());
+  bucket->SetInteger(base::StringPrintf(">= %" PRId64, max_),
+                     buckets_.back());
   histo->Append(bucket.release());
 
   return histo.Pass();
 }
 
 StatsEventSubscriber::StatsEventSubscriber(
     EventMediaType event_media_type,
     base::TickClock* clock,
     ReceiverTimeOffsetEstimator* offset_estimator)
     : event_media_type_(event_media_type),
@@ skipping 552 matching lines @@
     : event_counter(0), sum_size(0) {}
 StatsEventSubscriber::PacketLogStats::~PacketLogStats() {}
 
 StatsEventSubscriber::FrameInfo::FrameInfo() : encoded(false) {
 }
 StatsEventSubscriber::FrameInfo::~FrameInfo() {
 }
 
 }  // namespace cast
 }  // namespace media