Cast: Reduce the size of stats

media/cast/logging/stats_event_subscriber.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/logging/stats_event_subscriber.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
@@ skipping 41 matching lines @@
     size_t index = 1 + (sample - min_) / width_;
     DCHECK_LT(index, buckets_.size());
     ++buckets_[index];
   }
 }
 
 void StatsEventSubscriber::SimpleHistogram::Reset() {
   buckets_.assign(buckets_.size(), 0);
 }
 
-scoped_ptr<base::ListValue>
+scoped_ptr<base::DictionaryValue>

[imcheng, 2014/09/18 22:06:20]

The problem with this approach is that the buckets will no longer be in order,
since dictionary sorts their entries by key alphabetically. While that might
probably be ok when analyzing stats programatically, the histogram will become
harder to read for humans.

 StatsEventSubscriber::SimpleHistogram::GetHistogram() const {
-  scoped_ptr<base::ListValue> histo(new base::ListValue);
-
-  scoped_ptr<base::DictionaryValue> bucket(new base::DictionaryValue);
-
-  bucket->SetString("bucket", base::StringPrintf("< %" PRId64, min_));
-  bucket->SetInteger("count", buckets_.front());
-  histo->Append(bucket.release());
+  scoped_ptr<base::DictionaryValue> histo(new base::DictionaryValue);
+  histo->SetInteger(base::StringPrintf("< %" PRId64, min_), buckets_.front());
 
   for (size_t i = 1; i < buckets_.size() - 1; i++) {
-    bucket.reset(new base::DictionaryValue);
-
     int64 lower = min_ + (i - 1) * width_;
     int64 upper = lower + width_ - 1;
-    bucket->SetString(
-        "bucket", base::StringPrintf("%" PRId64 " - %" PRId64, lower, upper));
-    bucket->SetInteger("count", buckets_[i]);
-    histo->Append(bucket.release());
+    histo->SetInteger(
+        base::StringPrintf("%" PRId64 " - %" PRId64, lower, upper),
+        buckets_[i]);
   }
 
-  bucket.reset(new base::DictionaryValue);
-
-  bucket->SetString("bucket", base::StringPrintf(">= %" PRId64, max_));
-  bucket->SetInteger("count", buckets_.back());
-  histo->Append(bucket.release());
-
+  histo->SetInteger(base::StringPrintf(">= %" PRId64, max_), buckets_.back());
   return histo.Pass();
 }
 
 StatsEventSubscriber::StatsEventSubscriber(
     EventMediaType event_media_type,
     base::TickClock* clock,
     ReceiverTimeOffsetEstimator* offset_estimator)
     : event_media_type_(event_media_type),
       clock_(clock),
       offset_estimator_(offset_estimator),
@@ skipping 550 matching lines @@
     : event_counter(0), sum_size(0) {}
 StatsEventSubscriber::PacketLogStats::~PacketLogStats() {}
 
 StatsEventSubscriber::FrameInfo::FrameInfo() : encoded(false) {
 }
 StatsEventSubscriber::FrameInfo::~FrameInfo() {
 }
 
 }  // namespace cast
 }  // namespace media