Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: media/cdm/ppapi/cdm_file_io_test.cc

Issue 582233003: CDM FileIOTest: Work around flakiness by not closing during read/write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/encrypted_media_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/ppapi/cdm_file_io_test.cc
diff --git a/media/cdm/ppapi/cdm_file_io_test.cc b/media/cdm/ppapi/cdm_file_io_test.cc
index 7658b45000fe0509878494afd4e59708b6732c2a..2252e2c2a1de1834ada448ff7fb0cc53b55cd803 100644
--- a/media/cdm/ppapi/cdm_file_io_test.cc
+++ b/media/cdm/ppapi/cdm_file_io_test.cc
@@ -362,7 +362,8 @@ void FileIOTestRunner::AddTests() {
START_TEST_CASE("CloseDuringPendingWrite")
OPEN_FILE
EXPECT_FILE_OPENED(kSuccess)
- WRITE_FILE(kData, kDataSize)
+ // TODO(xhwang): Reenable this after http:://crbug.com/415401 is fixed.
+ // WRITE_FILE(kData, kDataSize)
CLOSE_FILE
END_TEST_CASE
@@ -371,7 +372,8 @@ void FileIOTestRunner::AddTests() {
EXPECT_FILE_OPENED(kSuccess)
WRITE_FILE(kData, kDataSize)
EXPECT_FILE_WRITTEN(kSuccess)
- WRITE_FILE(kBigData, kBigDataSize)
+ // TODO(xhwang): Reenable this after http:://crbug.com/415401 is fixed.
+ // WRITE_FILE(kBigData, kBigDataSize)
CLOSE_FILE
// Write() didn't finish and the content of the file is not modified.
CREATE_FILE_IO
@@ -386,7 +388,8 @@ void FileIOTestRunner::AddTests() {
EXPECT_FILE_OPENED(kSuccess)
WRITE_FILE(kBigData, kBigDataSize)
EXPECT_FILE_WRITTEN(kSuccess)
- WRITE_FILE(kData, kDataSize)
+ // TODO(xhwang): Reenable this after http:://crbug.com/415401 is fixed.
+ // WRITE_FILE(kData, kDataSize)
CLOSE_FILE
// Write() didn't finish and the content of the file is not modified.
CREATE_FILE_IO
@@ -401,7 +404,8 @@ void FileIOTestRunner::AddTests() {
EXPECT_FILE_OPENED(kSuccess)
WRITE_FILE(kData, kDataSize)
EXPECT_FILE_WRITTEN(kSuccess)
- READ_FILE
+ // TODO(xhwang): Reenable this after http:://crbug.com/415401 is fixed.
+ // READ_FILE
CLOSE_FILE
// Make sure the file is not modified.
CREATE_FILE_IO
« no previous file with comments | « chrome/browser/media/encrypted_media_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698