Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 582233003: CDM FileIOTest: Work around flakiness by not closing during read/write. (Closed)

Created:
6 years, 3 months ago by xhwang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, binji+watch_chromium.org, yusukes+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, noelallen1, tzik, mcasas+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, wjia+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

CDM FileIOTest: Work around flakiness by not closing during read/write. The flakiness is caused by issue 415401. Temporarily disable tests that close the FileIO during pending read or write. This also reenables ECKEncryptedMediaTest.FileIOTest by reverting commit 5af9a9c9d2d559014734c2eb2247d42f3fc0e740. BUG=415401, 415742 Committed: https://crrev.com/0c617e11d065c8104e9b96775363bdeb7dd1e68b Cr-Commit-Position: refs/heads/master@{#295726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M media/cdm/ppapi/cdm_file_io_test.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
PTAL
6 years, 3 months ago (2014-09-19 03:58:30 UTC) #2
ddorwin
lgtm
6 years, 3 months ago (2014-09-19 16:23:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582233003/1
6 years, 3 months ago (2014-09-19 16:49:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3dcdfbdb09c1bcd84784be6b2fb413fc687e37f9
6 years, 3 months ago (2014-09-19 17:33:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:34:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c617e11d065c8104e9b96775363bdeb7dd1e68b
Cr-Commit-Position: refs/heads/master@{#295726}

Powered by Google App Engine
This is Rietveld 408576698