Port live region ChromeVox tests.

Port live region ChromeVox tests.

This is 10/11 tests from upstream. All uses of setTimeout were removed to hopefully eliminate any flakiness.

Fixes bug where live region removals weren't spoken.

BUG=371692
Committed: https://crrev.com/339131328953573f4d7633b574dc34e7c2159341
Cr-Commit-Position: refs/heads/master@{#296015}

[dmazzoni, 2014-09-18 18:41:48]

dmazzoni@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2014-09-19 08:14:58]

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js:348:
navDescriptions = [cvox.DescriptionUtil.getDescriptionFromAncestors(
Can you mention this change to production code in the cl description?

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:31:
};
Do we want a tearDown that calls cvox.ChromeVoxTester.tearDown(document)
for sommetry?

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:41:
}, 300);
Yeah, let's not mention this to anyone... ;)  To check for flake caused by
timing, I usually --test-launcher-jobs=80 or similar when
running the tests.  That number works for me without flake with all current
chromevox_tests.  Maybe try a high number to see how much flake this adds.
I'd also make the 300 a global constant to make it less annoying to tweak.

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi (right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi:57:
'testing/spoken_list_builder.js',
This file doesn't need to be added here since it is picked up by
the test deps.js file (like all other goog.provide'ing files).  OTOH, it'd be
nice if you would add it to the CL;)

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:149:
assertSpokenList_: function(expectedList) {
nit: not private, so shouldn't have _ at the end.

[dmazzoni, 2014-09-22 07:14:55]

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js:348:
navDescriptions = [cvox.DescriptionUtil.getDescriptionFromAncestors(
On 2014/09/19 08:14:58, Peter Lundblad wrote:
> Can you mention this change to production code in the cl description?

Done.

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:31:
};
On 2014/09/19 08:14:58, Peter Lundblad wrote:
> Do we want a tearDown that calls cvox.ChromeVoxTester.tearDown(document)
> for sommetry?

Done.

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:41:
}, 300);
On 2014/09/19 08:14:58, Peter Lundblad wrote:
> Yeah, let's not mention this to anyone... ;)  To check for flake caused by
> timing, I usually --test-launcher-jobs=80 or similar when
> running the tests.  That number works for me without flake with all current
> chromevox_tests.  Maybe try a high number to see how much flake this adds.
> I'd also make the 300 a global constant to make it less annoying to tweak.

Good news, a bit more work and all setTimeouts are replaced with waitForCalm!
There should be no magic constants left.

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi (right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi:57:
'testing/spoken_list_builder.js',
On 2014/09/19 08:14:58, Peter Lundblad wrote:
> This file doesn't need to be added here since it is picked up by
> the test deps.js file (like all other goog.provide'ing files).  OTOH, it'd be
> nice if you would add it to the CL;)

Done.

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/582123002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:149:
assertSpokenList_: function(expectedList) {
On 2014/09/19 08:14:58, Peter Lundblad wrote:
> nit: not private, so shouldn't have _ at the end.

Done.

[Peter Lundblad, 2014-09-22 07:30:48]

lgtm

Now that you don't have any setTimeouts, you could stop mentioning that
in the cl description.  Minor nits below.

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:128:
* @param {function()} func A function to call when ChromeVox is ready.
nit: mention varargs

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:132:
// For convenience, execute the functions in the test case scope.
This would be more useful if mentioned in the description of the callback
in the jsdoc.

[dmazzoni, 2014-09-22 17:36:20]

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js
(right):

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:128:
* @param {function()} func A function to call when ChromeVox is ready.
On 2014/09/22 07:30:48, Peter Lundblad wrote:
> nit: mention varargs

Done.

https://codereview.chromium.org/582123002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:132:
// For convenience, execute the functions in the test case scope.
On 2014/09/22 07:30:48, Peter Lundblad wrote:
> This would be more useful if mentioned in the description of the callback
> in the jsdoc.

Done.

[dmazzoni, 2014-09-22 17:37:23]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-22 17:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582123002/60001

[commit-bot: I haz the power, 2014-09-22 18:25:18]

Committed patchset #4 (id:60001) as 15ac3c660554c401866d20716eb4be31445a5aa5

[commit-bot: I haz the power, 2014-09-22 18:26:00]

Patchset 4 (id:??) landed as
https://crrev.com/339131328953573f4d7633b574dc34e7c2159341
Cr-Commit-Position: refs/heads/master@{#296015}