Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 582103002: mac: Fix Yosemite crash while attempting to open multiple files. (Closed)

Created:
6 years, 3 months ago by erikchen
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix Yosemite crash while attempting to open multiple files. Attemping to open multiple files using the native Cocoa dialog causes a crash. This CL inserts a safety check to work around it. A Yosemite AppKit bug causes an NSWindowWillCloseNotification to be sent during the -dealloc for a specific NSWindow. Any autoreleases sent to that window must be drained before the window finishes -dealloc. BUG=406944 Committed: https://crrev.com/e4dd0bd72be65f663b638e956916af1ca9d7d245 Cr-Commit-Position: refs/heads/master@{#295507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
rsesek: Please review.
6 years, 3 months ago (2014-09-18 17:39:52 UTC) #2
Robert Sesek
LGTM assuming you've tested this manually on 10.10
6 years, 3 months ago (2014-09-18 17:45:39 UTC) #3
erikchen
yup. Crashes without this patch. Does not crash with patch.
6 years, 3 months ago (2014-09-18 17:48:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582103002/1
6 years, 3 months ago (2014-09-18 17:51:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as efa5f4e641ec5a1dfe90a9adeca6866a85c059b0
6 years, 3 months ago (2014-09-18 18:47:39 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:48:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4dd0bd72be65f663b638e956916af1ca9d7d245
Cr-Commit-Position: refs/heads/master@{#295507}

Powered by Google App Engine
This is Rietveld 408576698