content/browser/android/web_contents_observer_android.cc - Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_android.cc

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/web_contents_observer_android.h ('K') | « content/browser/android/web_contents_observer_android.h ('k') | content/browser/child_process_launcher.cc » ('j') | content/browser/child_process_launcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/web_contents_observer_android.cc

diff --git a/content/browser/android/web_contents_observer_android.cc b/content/browser/android/web_contents_observer_android.cc

index ca02612f29653bca40ca8c84d65651f6e0457b36..b105adef09f19e4166754ce33abcaf5c9dff91fb 100644

--- a/content/browser/android/web_contents_observer_android.cc

+++ b/content/browser/android/web_contents_observer_android.cc

@@ -60,6 +60,18 @@ void WebContentsObserverAndroid::WebContentsDestroyed(

}

+void WebContentsObserverAndroid::RenderProcessGone(

+ base::TerminationStatus termination_status) {

jar (doing other things) 2013/11/06 19:27:26 nit: 4 character indent from previous line's "v" i

ppi 2013/11/06 20:14:06 Done.

+ JNIEnv* env = AttachCurrentThread();

+ ScopedJavaLocalRef<jobject> obj(weak_java_observer_.get(env));

+ if (obj.is_null())

+ return;

+ jboolean was_oom_protected =

+ termination_status == base::TERMINATION_STATUS_OOM_PROTECTED;

+ Java_WebContentsObserverAndroid_renderProcessGone(

+ env, obj.obj(), was_oom_protected);

void WebContentsObserverAndroid::DidStartLoading(

RenderViewHost* render_view_host) {

JNIEnv* env = AttachCurrentThread();