content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Yaron's comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index b6d2e279a03eb24de12b4dfcc02c4ffa4e68bf73..f37bbe7c92dfe909112d52d1fb6ab08e5ee698f0 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -128,7 +128,7 @@ public class ContentView extends FrameLayout

@Override

public boolean isReadyForSnapshot() {

- return !isCrashed() && isReady();

+ return isReady();

}

@Override

@@ -662,13 +662,6 @@ public class ContentView extends FrameLayout

}

/**

- * @return Whether the native ContentView has crashed.

- */

- public boolean isCrashed() {

- return mContentViewCore.isCrashed();

- }

- /**

* Zooms in the WebView by 25% (or less if that would result in zooming in

* more than possible).