Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/process/kill.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.android_webview; 5 package org.chromium.android_webview;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.content.pm.ActivityInfo; 8 import android.content.pm.ActivityInfo;
9 import android.graphics.Bitmap; 9 import android.graphics.Bitmap;
10 import android.graphics.Picture; 10 import android.graphics.Picture;
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 mCachedRendererBackgroundColor = color == INVALID_COLOR ? 1 : color; 109 mCachedRendererBackgroundColor = color == INVALID_COLOR ? 1 : color;
110 } 110 }
111 111
112 @Override 112 @Override
113 public void onStartContentIntent(Context context, String contentUrl) { 113 public void onStartContentIntent(Context context, String contentUrl) {
114 // Callback when detecting a click on a content link. 114 // Callback when detecting a click on a content link.
115 AwContentsClient.this.shouldOverrideUrlLoading(contentUrl); 115 AwContentsClient.this.shouldOverrideUrlLoading(contentUrl);
116 } 116 }
117 117
118 @Override 118 @Override
119 public void onRendererCrash(boolean crashedWhileOomProtected) {
120 // This is not possible so long as the webview is run single process !
121 throw new RuntimeException("Renderer crash reported.");
122 }
123
124 @Override
125 public void onUpdateTitle(String title) { 119 public void onUpdateTitle(String title) {
126 AwContentsClient.this.onReceivedTitle(title); 120 AwContentsClient.this.onReceivedTitle(title);
127 } 121 }
128 122
129 @Override 123 @Override
130 public boolean shouldOverrideKeyEvent(KeyEvent event) { 124 public boolean shouldOverrideKeyEvent(KeyEvent event) {
131 return AwContentsClient.this.shouldOverrideKeyEvent(event); 125 return AwContentsClient.this.shouldOverrideKeyEvent(event);
132 } 126 }
133 127
134 @Override 128 @Override
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 public abstract void onFindResultReceived(int activeMatchOrdinal, int number OfMatches, 291 public abstract void onFindResultReceived(int activeMatchOrdinal, int number OfMatches,
298 boolean isDoneCounting); 292 boolean isDoneCounting);
299 293
300 /** 294 /**
301 * Called whenever there is a new content picture available. 295 * Called whenever there is a new content picture available.
302 * @param picture New picture. 296 * @param picture New picture.
303 */ 297 */
304 public abstract void onNewPicture(Picture picture); 298 public abstract void onNewPicture(Picture picture);
305 299
306 } 300 }
OLDNEW
« no previous file with comments | « no previous file | base/process/kill.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698