Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 58203002: Android: remove ContentViewCore from the renderer crash codepath. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.content.ActivityNotFoundException; 7 import android.content.ActivityNotFoundException;
8 import android.content.Context; 8 import android.content.Context;
9 import android.content.Intent; 9 import android.content.Intent;
10 import android.graphics.RectF; 10 import android.graphics.RectF;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 /** 45 /**
46 * Notifies the client that the position of the top controls has changed. 46 * Notifies the client that the position of the top controls has changed.
47 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels. 47 * @param topControlsOffsetYPix The Y offset of the top controls in physical pixels.
48 * @param contentOffsetYPix The Y offset of the content in physical pixels. 48 * @param contentOffsetYPix The Y offset of the content in physical pixels.
49 * @param overdrawBottomHeightPix The overdraw height. 49 * @param overdrawBottomHeightPix The overdraw height.
50 */ 50 */
51 public void onOffsetsForFullscreenChanged( 51 public void onOffsetsForFullscreenChanged(
52 float topControlsOffsetYPix, float contentOffsetYPix, float overdraw BottomHeightPix) { 52 float topControlsOffsetYPix, float contentOffsetYPix, float overdraw BottomHeightPix) {
53 } 53 }
54 54
55 /**
56 * Notifies the client that the renderer backing the ContentView has crashed .
57 * @param crashedWhileOomProtected True iff the renderer died while being bo und with a high
58 * priority binding, which indicates that it was probably an actual crash (a s opposed to the
59 * renderer being killed by the OS out-of-memory killer).
60 */
61 public void onRendererCrash(boolean processWasOomProtected) {
62 }
63
64 public boolean shouldOverrideKeyEvent(KeyEvent event) { 55 public boolean shouldOverrideKeyEvent(KeyEvent event) {
65 int keyCode = event.getKeyCode(); 56 int keyCode = event.getKeyCode();
66 // We need to send almost every key to WebKit. However: 57 // We need to send almost every key to WebKit. However:
67 // 1. We don't want to block the device on the renderer for 58 // 1. We don't want to block the device on the renderer for
68 // some keys like menu, home, call. 59 // some keys like menu, home, call.
69 // 2. There are no WebKit equivalents for some of these keys 60 // 2. There are no WebKit equivalents for some of these keys
70 // (see app/keyboard_codes_win.h) 61 // (see app/keyboard_codes_win.h)
71 // Note that these are not the same set as KeyEvent.isSystemKey: 62 // Note that these are not the same set as KeyEvent.isSystemKey:
72 // for instance, AKEYCODE_MEDIA_* will be dispatched to webkit. 63 // for instance, AKEYCODE_MEDIA_* will be dispatched to webkit.
73 if (keyCode == KeyEvent.KEYCODE_MENU || 64 if (keyCode == KeyEvent.KEYCODE_MENU ||
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 public void onExternalVideoSurfaceRequested(int playerId) { 176 public void onExternalVideoSurfaceRequested(int playerId) {
186 } 177 }
187 178
188 public void onGeometryChanged(int playerId, RectF rect) { 179 public void onGeometryChanged(int playerId, RectF rect) {
189 } 180 }
190 181
191 public ContentVideoViewClient getContentVideoViewClient() { 182 public ContentVideoViewClient getContentVideoViewClient() {
192 return null; 183 return null;
193 } 184 }
194 } 185 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698