Issue 582003003: Split revision into separate field on about:version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 582003003: Split revision into separate field on about:version. (Closed)

Created:
6 years, 3 months ago by Dan Beam

Modified:
6 years, 3 months ago

Reviewers:
agable

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Split revision into separate field on about:version. R=agable@chromium.org BUG=414994 Committed: https://crrev.com/3530cf952f2dbd636f32b521ec9a531fe811f1dd Cr-Commit-Position: refs/heads/master@{#295615}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/about_version.html	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/version_ui.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

agable

LGTM. I wasn't sure how to get an additional string for a label like "Revision" ...

6 years, 3 months ago (2014-09-18 19:13:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/582003003/20001

6 years, 3 months ago (2014-09-18 21:54:38 UTC) #3

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 0a5ac897d18e7e351160a6312e967dd3cc398d0a

6 years, 3 months ago (2014-09-19 00:02:21 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 00:02:49 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3530cf952f2dbd636f32b521ec9a531fe811f1dd
Cr-Commit-Position: refs/heads/master@{#295615}