Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 581993002: Introduce TypeFeedbackVector, as FixedArray grew constrictive. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce TypeFeedbackVector, as FixedArray grew constrictive. The TypeFeedbackVector is poised to host significant functionality. While it remains a FixedArray under the covers, we need a place to hold logic and definitions unique to its function. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24027

Patch Set 1 : Initial patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -38 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 4 chunks +5 lines, -3 lines 0 comments Download
M src/objects-inl.h View 3 chunks +5 lines, -1 line 0 comments Download
A src/type-feedback-vector.h View 1 chunk +34 lines, -0 lines 0 comments Download
A src/type-feedback-vector.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/type-info.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/type-info.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mvstanton
Hi Igor, Thx for the look, this just introduces the type, and methods will congregate ...
6 years, 3 months ago (2014-09-18 09:28:20 UTC) #3
Igor Sheludko
lgtm
6 years, 3 months ago (2014-09-18 09:37:52 UTC) #4
mvstanton
6 years, 3 months ago (2014-09-18 10:00:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as 24027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698