Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 581983003: Enable ASan default options on Mac. (Closed)

Created:
6 years, 3 months ago by Alexander Potapenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable ASan default options on Mac. This CL links libsanitizer_options into every executable built with ASan on OSX. The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds. BUG=302040 R=cpu@chromium.org Committed: https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955 Cr-Commit-Position: refs/heads/master@{#295958}

Patch Set 1 #

Patch Set 2 : More strict condition #

Patch Set 3 : Fix chromeos compile #

Patch Set 4 : Moved the dependency to target_defaults #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -46 lines) Patch
M build/common.gypi View 1 2 3 4 chunks +10 lines, -9 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M build/sanitizers/sanitizers.gyp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/app/chrome_exe_main_mac.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/app/framework.order View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Alexander Potapenko
Carlos, may I ask you to take a look?
6 years, 3 months ago (2014-09-18 13:11:47 UTC) #2
Alexander Potapenko
+Sergey for another pair of eyes on GYP
6 years, 3 months ago (2014-09-18 13:12:47 UTC) #4
earthdok
lgtm
6 years, 3 months ago (2014-09-19 12:51:06 UTC) #5
cpu_(ooo_6.6-7.5)
rubber-stamp lgtm
6 years, 3 months ago (2014-09-19 18:21:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/581983003/60001
6 years, 3 months ago (2014-09-22 12:22:07 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as bde5f70d022b914fcae2d0687a94ef9672c93993
6 years, 3 months ago (2014-09-22 13:20:22 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0640a5d19ef72aec62787423e8a7c78c4f62b955 Cr-Commit-Position: refs/heads/master@{#295958}
6 years, 3 months ago (2014-09-22 13:20:59 UTC) #10
Alexander Potapenko
6 years, 3 months ago (2014-09-22 16:31:45 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/593683004/ by glider@chromium.org.

The reason for reverting is: This CL broke ui_unittests on both Mac ASan and Mac
ASan 64 bots:

/Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests
--brave-new-test-launcher --test-launcher-bot-mode --verbose
--test-launcher-print-test-stdio=always --gtest_print_time
--test-launcher-summary-output=/tmp/tmpnPVxX8
dyld: Library not loaded: @executable_path/../Versions/1.0.0.0/ui_unittests
Framework.framework/ui_unittests Framework
  Referenced from:
/Volumes/data/bool/build/slave/Mac_ASan_Tests__2_/build/src/out/Release/ui_unittests
  Reason: image not found

http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%28....

Powered by Google App Engine
This is Rietveld 408576698